Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cxx-interop] fix the C++ methods dispatch for the Windows target #66326

Closed
Tracked by #65808
hyp opened this issue Jun 5, 2023 · 1 comment · Fixed by #67268 or #67442
Closed
Tracked by #65808

[cxx-interop] fix the C++ methods dispatch for the Windows target #66326

hyp opened this issue Jun 5, 2023 · 1 comment · Fixed by #67268 or #67442
Assignees
@hyp
Labels
affects ABI Flag: Affects ABI bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. c++ interop Feature: Interoperability with C++ compiler The Swift compiler itself IRGen LLVM IR generation swift 5.9 Windows Platform: Windows

Comments

@hyp
Copy link
Contributor

hyp commented Jun 5, 2023

Right now on Windows several C++ interop tests don't work as their methods aren't dispatched correctly. We need to fix it in Swift 5.9.
@hyp hyp added bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. c++ interop Feature: Interoperability with C++ triage needed This issue needs more specific labels swift 5.9 labels Jun 5, 2023
@hyp hyp self-assigned this Jun 5, 2023
This was referenced Jun 5, 2023
Open
Closed
hyp added a commit to hyp/swift that referenced this issue Jul 14, 2023
@hyp
[cxx-interop] Fix the windows ABI for returning indirect values out o…
c09135b 
…f methods

Fixes swiftlang#66326

This allows us to reneable Windows method tests. Note that Windows still has
a broken convention for non-trivial record with non-trivial destructor but
trivial copy-constructor, so classes in the methods.swift test need an explicit
copy constructor.

Fixes rdar://88391102
hyp added a commit to hyp/swift that referenced this issue Jul 20, 2023
@hyp
[cxx-interop] Fix the windows ABI for returning indirect values out o…
77b5409 
…f methods

Fixes swiftlang#66326

This allows us to reneable Windows method tests. Note that Windows still has
a broken convention for non-trivial record with non-trivial destructor but
trivial copy-constructor, so classes in the methods.swift test need an explicit
copy constructor.

Fixes rdar://88391102
@hyp
Copy link
Contributor Author

hyp commented Jul 20, 2023

#67268
and
#67442

This was linked to pull requests Jul 20, 2023
[cxx-interop] windows methods fixes #67268
Merged
[cxx-interop][5.9] windows ABI fixes #67442
Merged
@AnthonyLatsis AnthonyLatsis added Windows Platform: Windows compiler The Swift compiler itself IRGen LLVM IR generation affects ABI Flag: Affects ABI and removed triage needed This issue needs more specific labels labels Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hyp hyp

Labels
affects ABI Flag: Affects ABI bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. c++ interop Feature: Interoperability with C++ compiler The Swift compiler itself IRGen LLVM IR generation swift 5.9 Windows Platform: Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[cxx-interop] windows methods fixes hyp/swift
[cxx-interop][5.9] windows ABI fixes hyp/swift
2 participants
@hyp @AnthonyLatsis