Add a custom @_spi kind to expose BumpPtrAllocator from SwiftSyntax to ASTGen.

[ahoppen]

Mark BumpPtrAllocator as @_spi(BumpPtrAllocator) and change @_spi(RawSyntax) import SwiftSyntax in ASTGen.swift to @_spi(BumpPtrAllocator) import SwiftSyntax.

That way, ASTGen doesn’t need to import SwiftSyntax with @_spi(RawSyntax).

[ChiduAnush]

hello, I am a total newbie to open source. Would be great if I could start woking on this. just confirming, i just need to find and replace right?.
thank you

[ahoppen]

Yes, should be quite straightforward. Just note that the apple/swift side of this issue depends on #67111 being merged.

[ChiduAnush]

what does that mean? sorry if this is a very basic doubt. should I fork the repo and start to work now then? or wait?

[ahoppen]

I think it’s probably easiest if you just wait until #67111 is merged.

[ChiduAnush]

ah that's great. thank you so much. will keep an eye out

[veryharsh123]

Can I work on the issue?

[AnthonyLatsis]

@ChiduAnush Are you still keen to work on this?

[ChiduAnush]

Yes, would be great if you could assign it

[AnthonyLatsis]

Yes, would be great if you could assign it

You're already assigned!

---

@veryharsh123 Do you mind deferring this issue to @ChiduAnush since he was already assigned?

[ChiduAnush]

can you tell me what exactly do you mean by Mark BumpPtrAllocator as @_spi(BumpPtrAllocator)?

[AnthonyLatsis]

Sure. swift/main depends on swift-syntax/main, so you need 2 simultaneous pull requests to pull this off: one in https://github.com/apple/swift-syntax that marks the BumpPtrAllocator class as @_spi(BumpPtrAllocator) instead of @_spi(RawSyntax), and a second one in this repository that updates the import declaration in ASTGen.swift.

[ChiduAnush]

please check and let me know if everything is all right.

[ahoppen]

I think you also need to change the import of SwiftSyntax in ASTGen.swift to be @_spi(BumpPtrAllocator)

https://github.com/apple/swift/blob/95330bcc5bf95a1bf1ff3a00d71d701101af57eb/lib/ASTGen/Sources/ASTGen/ASTGen.swift#L7

[ChiduAnush]

I already did that. There are 2 pull requests.

[ahoppen]

Oh, sorry. I didn’t see your PR to apple/swift. In general, if you have two PRs that are linked like that, it’s good practice to reference the accompanying PR in the other repo in the PR’s description.