[mandatory-inline] Extract out tryDevirtualizeCode into its own helper function. NFC. #11839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test and merge |
|
Actually this is wrong. I need to fix this. brb. |
|
I just killed the job. |
gottesmm
force-pushed
the
pr-8aae8140c859cc0621e37aa723e638253cf585b7
branch
from
290fead to
ca2c91b
Compare
|
Ok. Now lets try this again... |
|
@swift-ci smoke test and merge |
1 similar comment
|
@swift-ci smoke test and merge |
|
sigh need to use make_tuple |
…r function. NFC. Just trying to slim down/refactor this huge loop. rdar://31521023
gottesmm
force-pushed
the
pr-8aae8140c859cc0621e37aa723e638253cf585b7
branch
from
ca2c91b to
600edc3
Compare
|
@swift-ci smoke test and merge |
ktoso
added a commit
to ktoso/swift
that referenced
this pull request
May 1, 2025
We missed to sign the handler. Along the way the signature of it
changed, so adjust for that.
How to get the number:
```
func PROPER(bar: (TaskPriority, TaskPriority) -> Void) {
let p = TaskPriority.default
bar(p, p)
}
```
```
-> % swiftc -target arm64e-apple-macos13 example.swift -S -o - | swift demangle | grep -a3 autda
stur x8, [x29, #-64]
mov x17, x8
movk x17, swiftlang#11839, lsl swiftlang#48 <<<<<<<<<
autda x16, x17
ldr x8, [x16, swiftlang#64]
lsr x8, x8, #0
add x8, x8, swiftlang#15
```
Resolves rdar://150378890
ktoso
added a commit
to ktoso/swift
that referenced
this pull request
May 1, 2025
We missed to sign the handler. Along the way the signature of it
changed, so adjust for that.
How to get the number:
```
func PROPER(bar: (TaskPriority, TaskPriority) -> Void) {
let p = TaskPriority.default
bar(p, p)
}
```
```
-> % swiftc -target arm64e-apple-macos13 example.swift -S -o - | swift demangle | grep -a3 autda
stur x8, [x29, #-64]
mov x17, x8
movk x17, swiftlang#11839, lsl swiftlang#48 <<<<<<<<<
autda x16, x17
ldr x8, [x16, swiftlang#64]
lsr x8, x8, #0
add x8, x8, swiftlang#15
```
Resolves rdar://150378890
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[mandatory-inline] Extract out tryDevirtualizeCode into its own helper function. NFC.
Just trying to slim down/refactor this huge loop.
rdar://31521023