[Clang Importer] Import ns_error_domain attribute with _BridgedNSError #1192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces new class, EnumInfo, just for the implementation of the ClangImporter to encapsulate various computed information about the enum we're importing. This helps refactor some functionality, aids clarity, and also prevents us from repeating calculations multiple times, as we were doing with classifyEnum's macro-expansion tracking. Provides a base where we can add more heavy lifting in classifyEnum in the future.
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
ns_error_domain can now be used to communicate with the ClangImporter when an enum has an associated error domain string. In this case, when we import it as a Swift enum, we can also synthesize a conformance to _BridgedNSError. This allows the creation of something like NS_ERROR_ENUM, in which the developer can declare an enum for the purposes of error handling. Adds Sema and executable tests demonstrating this funcionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes. First is a refactoring of some of the common enum reasoning which also lays down a base for ns_error_domain handling. Second introduces support for ns_error_domain.