[AST] Verify canonicalization of generic signatures. #12774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that we always get the underlying concrete type or the anchor of a particular equivalence class.
|
@swift-ci please smoke test and merge |
We’re substituting in the conformance type for Self, nothing more.
If substitution into the generic parameters of a generic function type changes those generic parameters, build a new generic signature from the resulting parameters. Otherwise, we can end up building ill-formed generic signatures that fail validation.
When we canonicalize a generic signature, ensure that the resulting signature has canonical requirements in the appropriate order. More validation for generic signature canonicalization as part of the ABI, which is tracked by SR-3733 / rdar://problem/31412994.
DougGregor
force-pushed
the
gsb-validate-canonicalization
branch
from
cd42ca3
to
c5fe5c4
Compare
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we canonicalize a generic signature, ensure that the resulting
signature has canonical requirements in the appropriate order.
More validation for generic signature canonicalization as part of the
ABI, which is tracked by SR-3733 / rdar://problem/31412994.