Diagnose Circular Typealiases in Protocols #138
Conversation
| @@ -573,6 +573,9 @@ class alignas(1 << DeclAlignInBits) Decl { | |||
| unsigned : NumTypeDeclBits; | |||
|
|
|||
| unsigned Recursive : 1; | |||
|
|
|||
| /// Whether or not this declaration is currently being type-checked. | |||
| unsigned BeingTypeChecked : 1; | |||
| }; | |||
| enum { NumAssociatedTypeDeclBits = NumTypeDeclBits + 1 }; | |||
There was a problem hiding this comment.
Needs to be bumped from + 1 to + 2.
There was a problem hiding this comment.
@cwillmor Great catch! Thanks.
|
Hi @CodaFi, would be better if you could rebase against master. This way your patch will avoid merge-commits, that are not needed usually. See this article for more details: |
|
@AlexDenisov I've been rebasing. Do you mean I should squash? |
|
@CodaFi I see there are few merge commits ('merge branch master ...'), besides that it could be one commit.
the correct answer might be "rebase and squash" :) |
CodaFi
force-pushed
the
the-circular-typealias-of-life
branch
from
de9cc72 to
214575b
Compare
|
@AlexDenisov Ah, I see what was happening. Wrong script! |
|
@CodaFi thank you, not it looks better. You may think about such changes as of one atomic patch ;) |
|
It seems that the Swift team do not subscribe to the dogmatic view that rewriting history outside mainline is bad! ( 🎉 ) |
|
@DougGregor I believe this is ready for review when you're ready. |
CodaFi
force-pushed
the
the-circular-typealias-of-life
branch
from
214575b to
9b68f5f
Compare
| @@ -3173,7 +3173,7 @@ class DeclChecker : public DeclVisitor<DeclChecker> { | |||
| TAD->getUnderlyingTypeLoc().setInvalidType(TC.Context); | |||
| } else if (TAD->getDeclContext()->isGenericContext()) { | |||
| TAD->setInterfaceType( | |||
| TC.getInterfaceTypeFromInternalType(TAD->getDeclContext(), | |||
| TC.getInterfaceTypeFromInternalType(TAD->getDeclContext(), | |||
| TAD->getType())); | |||
There was a problem hiding this comment.
Unnecessary whitespace change here.
There was a problem hiding this comment.
I would go as far as saying that white space had meaning and now is gone. It was enforcing that getInterfaceTypeFromInternalType is an argument passed to setInterfaceType.
It's merged now but would you oppose adding this space back in? I'm not one for PR (just to correct this) with such minimal changes but...
Diagnose Circular Typealiases in Protocols
This crashing test became non-crashing in swiftlang#138. swiftlang#138 also emitted multiple instances of the same diagnostic, which was causing -verify to fail on decl/protocol/req/recursion.swift.
Support throws/rethrows in function decls.
Added Toolchain section in INSTALL.md
Added Toolchain section in INSTALL.md Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
* Add swift_symbolgraph_extract variable for wasi to run lit test * [WASM] Update WASI SDK to 0.2.0 When using wasm-ld in wasi-sdk 0.1.0-swiftwasm, some test cases in swift are failed with "failed to demangle witness for associated type 'Iterator' in conformance 'Swift.UInt64.Words: Sequence' from mangled name '$e'" message. This message means that runtime library fails to look up for protocol conformance from swift5_protocol_conformances section. In WebAssembly binary, these protocol conformances data are stored in data segments in each object files and link them into one segment by wasm-ld. Swift runtime library uses special __start and __stop symbols to point where the metadata section is located. These special symbols are emitted by linker wasm-ld. But wasm-ld in wasi-sdk 0.1.0 emitited them for each data segments without combining them by their name. This causes the crash if an user code has a protocol conformance because __start and __stop symbols point only the user defined protocol conformance segment. The wasm-ld bug has been fixed by this patch https://reviews.llvm.org/D64148
…vbar Add Swift 4 commit for AMScrollingNavbar
Fixes a longstanding issue where declarations of the form
would accidentally crash the compiler by sending the AST visitor into a loop with the typechecker.
The error
type alias 'X' circularly references itselfis now emitted at the declaration site.