[WIP][CSSolver] Attempt to remove type-checker hacks #15246
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test source compatibility |
Contributor
Author
|
@swift-ci please smoke test macOS platform |
Contributor
Author
…atch If overload set contains both protocol requirement and its witnesses let's only leave requirement itself active until we know that it matches, in such case we'd re-enable witness methods and attempt them. This helps to significantly reduce the number of overload choices we consider upfront e.g. for '==' operator we can hide 53 choices behind Equatable protocol from total number of 68 choices.
Constraint system "shrinking" only gets in the way now since it can't properly reduce domains with generic solutions.
In expressions like `x + y + foo()` try to optimize constraint system by favoring choice at the same position for immediately reachable operator. This "softly" exploits the fact that most of the expressions with linked arithmetic/conditional operators are homogeneous.
…iterals To speed up type-checking for numeric literal types let's try to implicitly convert expressions like `UInt32(42)` into `42 as UInt32` but only if requested type conforms to the correct literal protocol. The desired outcome is that we can properly type-check expressions like `UInt64(0xffff_ffff_ffff_ffff)` and speed up solving of more complex expressions by avoiding checking all of the initializer overloads since most of them are likely unrelated.
Contributor
Author
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to simplify the solver by removing (and replacing) most of the hacks.