[4.2][stdlib] Make sure _SwiftNewtypeWrapper hashes the same way as its RawValue #15991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts RawValue _SwiftNewtypeWrapper forwarded hashValue to its rawValue, but it failed to do the same for _hash(into:), which resulted in the wrapper struct having subtly different hashing than the raw value. This violated an implicit invariant when dictionaries/sets of such types were bridged to Objective-C through AnyHashable, leading to nondeterministic but frequent crashes. rdar://problem/39398060 (cherry picked from commit 6c5a6a6)
|
@swift-ci please smoke test |
|
@DougGregor could you take a quick look? Note that I had to add the new |
airspeedswift
approved these changes
Apr 17, 2018
|
@airspeedswift PR #15939 includes an update to the test suite's |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_SwiftNewtypeWrapperforwarded hashValue to its rawValue, but it failed to do the same for_hash(into:), which resulted in the wrapper struct having subtly different hashing than the raw value.This violated an implicit invariant when dictionaries/sets of such types were bridged to Objective-C through
AnyHashable, leading to nondeterministic but frequent crashes.rdar://problem/39398060
(cherry picked from commit 6c5a6a6)