Disable really large Data tests that take a bit too long to run #20411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
eeckstein
requested changes
Nov 7, 2018
| BenchmarkInfo(name: "DataCreateEmptyArray", runFunction: run_createEmptyArray, tags: [.validation, .api, .Data]), | ||
| BenchmarkInfo(name: "DataCreateSmallArray", runFunction: run_createSmallArray, tags: [.validation, .api, .Data]), | ||
| BenchmarkInfo(name: "DataCreateMediumArray", runFunction: run_createMediumArray, tags: [.validation, .api, .Data]), | ||
| BenchmarkInfo(name: "DataSubscriptSmall", runFunction: run_SubscriptSmall, tags: [.validation, .api, .Data]), | ||
| BenchmarkInfo(name: "DataSubscriptMedium", runFunction: run_SubscriptMedium, tags: [.validation, .api, .Data]), | ||
| BenchmarkInfo(name: "DataSubscriptLarge", runFunction: run_SubscriptLarge, tags: [.validation, .api, .Data]), | ||
| BenchmarkInfo(name: "DataSubscriptLarge", runFunction: run_SubscriptLarge, tags: [.validation, .api, .Data, .skip]), | ||
| BenchmarkInfo(name: "DataCountSmall", runFunction: run_CountSmall, tags: [.validation, .api, .Data]), | ||
| BenchmarkInfo(name: "DataCountMedium", runFunction: run_CountMedium, tags: [.validation, .api, .Data]), | ||
| BenchmarkInfo(name: "DataCountLarge", runFunction: run_CountLarge, tags: [.validation, .api, .Data]), |
There was a problem hiding this comment.
Can you also disable this one. It also takes long.
phausler
force-pushed
the
disable_large_data_benchmarks
branch
from
98f3341 to
ff26e96
Compare
|
@swift-ci please smoke test and merge |
|
While we're looking, |
|
@swift-ci please smoke test |
eeckstein
approved these changes
Nov 9, 2018
|
@phausler just a suggestion. Maybe we should have a .long tag or something like that (and maybe run them during the long test?) not sure. |
|
@airspeedswift Re: noisy |
This was referenced Dec 20, 2018
palimondo
added a commit
to palimondo/swift
that referenced
this pull request
Jan 4, 2019
Refactored to use shared test method and inlined runFunctions. Extracted setup overhead. Re-enabled `Large` tests errorneously disabled in swiftlang#20411.
palimondo
added a commit
to palimondo/swift
that referenced
this pull request
Jan 4, 2019
Refactored to use shared test method and inlined runFunctions. Re-enabled `Large` test errorneously disabled in swiftlang#20411. Removed `skip` tags, as this was the last use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benchmarks for Data are a bit harsh for CI to run. This disables the really big ones.