Move the similar function merging pass into the LLVM repo #20451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
apple/swift-llvm#123 |
|
LGTM |
This fixes a link error in swift-llvm-opt.
|
apple/swift-llvm#123 |
|
apple/swift-llvm#123 |
|
@eeckstein @aschwaighofer thanks for the reviews! Here's my plan for landing this:
Does that sound right? |
|
On second thought, it might be more difficult to maintain a copy of this pass in the upstream-with-swift branch, as it would require more effort to keep it in sync with llvm.org. Let's wait until we can really upstream this pass to do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to experiment with function merging in clang.
This set of PRs just does pure code movement.
Depends on:
apple/swift-llvm#123
apple/swift-clang#231
rdar://45707083