Skip to content

[benchmark] Janitor Duty: Lexicon Legacy #21794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 11, 2019

Conversation

palimondo
Copy link
Contributor

@palimondo palimondo commented Jan 11, 2019

This PR follows-up #20861, #21413 and #21516. It's a next batch of benchmark clean-up to enable robust performance measurements by adjusting workloads to run in reasonable time (< 1000 μs), minimizing the accumulated error. To maintain long-term performance tracking, it applies legacy factor where necessary.

This one's about Dicts...

@palimondo palimondo changed the title [WIP][benchmark] Janitor Duty: Lexicon Legacy [WIP][benchmark] Janitor Duty, Legacy Factor: Lexicon Jan 11, 2019
@palimondo palimondo changed the title [WIP][benchmark] Janitor Duty, Legacy Factor: Lexicon [WIP][benchmark] Janitor Duty: Lexicon Legacy Jan 11, 2019
@swift-ci

This comment has been minimized.

@palimondo
Copy link
Contributor Author

@swift-ci please benchmark

@palimondo
Copy link
Contributor Author

@swift-ci please smoke test

@swift-ci

This comment has been minimized.

@palimondo palimondo force-pushed the a-tall-white-fountain-played branch from 22c3951 to eadb243 Compare January 11, 2019 21:43
@palimondo
Copy link
Contributor Author

@swift-ci please benchmark

@swift-ci
Copy link
Contributor

Build comment file:

Performance: -O

TEST OLD NEW DELTA RATIO
Regression
DataAppendDataLargeToLarge 37600 51400 +36.7% 0.73x (?)
ObjectiveCBridgeStubToNSDate2 1236 1338 +8.3% 0.92x (?)
Improvement
ObjectiveCBridgeStubFromArrayOfNSString2 3471 3219 -7.3% 1.08x (?)

Performance: -Osize

TEST OLD NEW DELTA RATIO
Improvement
DataAppendDataLargeToLarge 51400 37400 -27.2% 1.37x (?)

Code size: -Osize

TEST OLD NEW DELTA RATIO
Improvement
DictTest2.o 9833 9721 -1.1% 1.01x

Performance: -Onone

TEST OLD NEW DELTA RATIO
Regression
ObjectiveCBridgeToNSDictionary 16551 18392 +11.1% 0.90x (?)
Improvement
DataAppendDataLargeToLarge 51400 38400 -25.3% 1.34x (?)
How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB
--------------

@palimondo
Copy link
Contributor Author

@swift-ci please smoke test

@palimondo
Copy link
Contributor Author

@eeckstein Please review 🙏 (Today just a short one… I'm burnt out in this 🚽)

@eeckstein eeckstein self-requested a review January 11, 2019 23:14
@palimondo palimondo merged commit b849427 into swiftlang:master Jan 11, 2019
@palimondo
Copy link
Contributor Author

Thank you Erik!

@palimondo palimondo changed the title [WIP][benchmark] Janitor Duty: Lexicon Legacy [benchmark] Janitor Duty: Lexicon Legacy Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants