[test] Add Android (and FreeBSD) to OS checks #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Android to the OS checks used to determine whether to import Glibc. These tests would pass on Android were it not for the fact that Android is not included in the Glibc check. Also add FreeBSD where missing.
|
Sounds sensible to me. I can't test right away either. Thanks. |
|
@swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Add Android to the OS checks used to determine whether to import Glibc. These tests would pass on Android were it not for the fact that Android is not included in the Glibc check.
Also add FreeBSD where missing. I don't yet have a FreeBSD development environment handy, so I can't say for sure whether these pass. /cc @dcci
Android tests are not currently run, but I'm working on that in #1714. These tests pass when run using the Android test config from that pull request.
Resolved bug number: None
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.