[IRGen] Rewrite dead method test in StdlibUnittest #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test and merge |
StdlibUnitest is the preferred system for testing that a certain piece of code crashes. It's also the only way to get this test to pass when run on an Android host device, since otherwise the device test runner exits before confirming the output via FileCheck.
modocache
force-pushed
the
test-irgen-report-dead-method-call-stdlibunittest
branch
from
a4c6599
to
e1ed229
Compare
|
Ack, silly me! Included a typo. Sorry for wasting CI CPU cycles. Could you please try another "test and merge"? |
|
@swift-ci Please test and merge |
|
Tests succeeded, but the merge API call failed. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
StdlibUnitest is the preferred system for testing that a certain piece of code crashes. It's also the only way to get this test to pass when run on an Android host device, since otherwise the device test runner exits before confirming the output via
FileCheck.Related pull request: #1714
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.