Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Property delegates #23440

Closed
wants to merge 46 commits into from
Closed

[WIP] Property delegates #23440

wants to merge 46 commits into from

Conversation

DougGregor
Copy link
Member

@DougGregor DougGregor commented Mar 20, 2019 •
edited
Loading

This is the implementation of the Property Delegates feature currently being pitched on the forums. Or, you can read the proposal.

The implementation has a few notable limitations:

  • libSyntax/SwiftSyntax support is missing
  • Backing storage properties for locally-scoped properties with delegates can't be found by name lookup

This was referenced Mar 20, 2019
Closed
Closed
@mackoj mackoj mentioned this pull request Mar 20, 2019
Closed
@DougGregor
Copy link
Member Author

@swift-ci please test source compatibility

3 similar comments
@DougGregor
Copy link
Member Author

@swift-ci please test source compatibility

@DougGregor
Copy link
Member Author

@swift-ci please test source compatibility

@DougGregor
Copy link
Member Author

@swift-ci please test source compatibility

@DougGregor
Copy link
Member Author

@swift-ci please test source compatibility release

1 similar comment
@DougGregor
Copy link
Member Author

@swift-ci please test source compatibility release

@fassko fassko mentioned this pull request Mar 22, 2019
Closed
@DougGregor DougGregor added the swift evolution pending discussion Flag → feature: A feature that has a Swift evolution proposal currently in review label Mar 22, 2019
@DougGregor
Copy link
Member Author

@swift-ci please smoke test

1 similar comment
@DougGregor
Copy link
Member Author

@swift-ci please smoke test

@DougGregor
Copy link
Member Author

@swift-ci please test source compatibility

1 similar comment
@DougGregor
Copy link
Member Author

@swift-ci please test source compatibility

@DougGregor
Copy link
Member Author

apple/swift-lldb#1402 should fix the LLDB compiler error

@DougGregor
Copy link
Member Author

@swift-ci please smoke test

@DougGregor
Copy link
Member Author

@swift-ci please build toolchain

@DougGregor
Copy link
Member Author

@swift-ci please smoke test

@DougGregor
Copy link
Member Author

@swift-ci please build toolchain

1 similar comment
@DougGregor
Copy link
Member Author

@swift-ci please build toolchain

@swift-ci
Copy link
Contributor

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - c4fcb6a4c45fd9c1c7dd0eba5bdbda8b585152a3

Install command
tar zxf swift-PR-23440-175-ubuntu16.04.tar.gz
More info

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - c4fcb6a4c45fd9c1c7dd0eba5bdbda8b585152a3

Install command
tar -zxf swift-PR-23440-230-osx.tar.gz --directory ~/

@DougGregor
Copy link
Member Author

@swift-ci please smoke test

@DougGregor
Copy link
Member Author

@swift-ci please build toolchain

@DougGregor
Copy link
Member Author

@swift-ci please smoke test

@DougGregor
Copy link
Member Author

@swift-ci please build toolchain

@swift-ci
Copy link
Contributor

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - e0b2d40ea7fe2a536d1cbdada5cb27490b432e68

Install command
tar zxf swift-PR-23440-177-ubuntu16.04.tar.gz
More info

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - e0b2d40ea7fe2a536d1cbdada5cb27490b432e68

Install command
tar -zxf swift-PR-23440-232-osx.tar.gz --directory ~/

@DougGregor
[Property delegates] Walk the property delegate type in ASTWalker.
d9ca581 
This makes anything nased on the ASTWalker, such as indexing, also take
attached property delegates into account.
@DougGregor
[Property delegates] Don't contextualize property initializer twice.
a17ff53
@DougGregor
[Property delegates] Diagnose protocol/enum/extension restrictions.
789dad4
@DougGregor
[Property delegates] Diagnose final/override restrictions on properties.
fb8c6a6
@DougGregor
[Property delegates] Diagnose conflicting attributes/modifiers.
513aa6d
@DougGregor
[Property delegate] A property with a delegate may not declare access…
f6c8a82 
…ors.
@DougGregor
[Type checker] Don't complain about missing 'override' that we deleted.
05b6db7
@DougGregor
Remove now-obsolete -verify-sil-ownership flag
c6e530a
@DougGregor
[Property delegates] Allow explicit get/set in a property with a dele…
1adb066 
…gate.

Lift the ban on explicitly defining get/set in a property that has a
delegate. Instead, synthesize which of them are missing.
@DougGregor
[Property delegates] Disable default arguments for the memberwise ini…
9848419 
…tializer.

SE-0242 was merged, and I haven't yet figured out how it interacts with
property delegates. Disabled default arguments in the memberwise
initializer for properties that have delegates until I have a design +
implementation.
@DougGregor
[Property delegates] Clean up & test handling of mutating/nonmutating.
4bfb212
@DougGregor
[Property delegates] Don't implicitly reference a private(set) 'value'.
9017c7e 
If a property delegate type's 'value' property has a private setter, don't
create a setter for a property that uses that delegate type.
@DougGregor
[Property delegates] Diagnose too-restrictive 'value' and 'init(initi…
78e8a36 
…alValue:)' .

The 'value' property and 'init(initialValue:)' initializer cannot have
more restrictive access than the property delegate itself. Diagnose
this.
@DougGregor
[Property delegates] Model delegate backing storage access as a “target”
00d6964 
Rather than hardcoding the access patterns for the backing property of
a property with a delegate, extend the “target implementation” notion
used to abstract property access for code synthesis to understand the
delegate pattern. This collapses the getter/setter implementation into
the “trivial” cases uses the delegate access pattern.

As a bonus, we get @_transparent when it makes sense.
@DougGregor
[Property delegates] Support didSet/willSet.
32430ec 
A property with a delegate can provide didSet/willSet. Synthesize a setter
that calls didSet/willSet appropriately for such properties.
@DougGregor
Copy link
Member Author

@swift-ci please smoke test

@DougGregor
Copy link
Member Author

@swift-ci please build toolchain

@DougGregor
Copy link
Member Author

@swift-ci please test source compatibility

@swift-ci
Copy link
Contributor

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 32430ec

Install command
tar zxf swift-PR-23440-185-ubuntu16.04.tar.gz
More info

@DougGregor
Move simple_display(... PropertyDelegateTypeInfo ...) into libswiftAST.
43b3c59
@DougGregor
[Property delegates] Reject delegates on local properties.
4feb812 
The implementation to support delegates on local properties has grown
past the point where I feel comfortable committing it now, so an
delegates on local properties for now.
@DougGregor
[Experimental] Parse custom attributes that can refer to property del…
23a76d4 
…egates.

Parse custom attributes with the grammer

```
  '@' type-identifier expr-paren?
```

When the type-identifier refers to a nominal type with the
@propertyDelegate attribute, treat this as being equivalent to

```swift
  by type-identifier expr-paren?
```
@DougGregor
Restrict custom attributes to those that start with an uppercase letter
4107789
@DougGregor
Copy link
Member Author

@swift-ci please build toolchain

1 similar comment
@DougGregor
Copy link
Member Author

@swift-ci please build toolchain

@DougGregor
Copy link
Member Author

This was obsoleted by the "custom attributes" approach

@DougGregor DougGregor closed this May 4, 2019
@AnthonyLatsis AnthonyLatsis removed the swift evolution pending discussion Flag → feature: A feature that has a Swift evolution proposal currently in review label Apr 18, 2023
@AnthonyLatsis
Copy link
Collaborator

Proposal: SE-0030.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DougGregor @swift-ci @AnthonyLatsis