Skip to content

Convert ArrayExpr to not use callWitness() or generate a SemanticExpr. #23618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 28, 2019

Conversation

slavapestov
Copy link
Contributor

@slavapestov slavapestov commented Mar 28, 2019

This PR builds on @pschuh's #23177. @pschuh did not have a Mac to test so I helped fix an issue specific to bridging conversions. See the original PR for motivation and review discussion.

  • The first commit is from the original PR
  • Second commit fixes the bridging issue
  • Followed by two cleanups of some related code that was already in SILGen
  • Followed by another fix to properly clean up uninitialized arrays when an array literal contains throwing expressions

@slavapestov slavapestov requested a review from pschuh March 28, 2019 03:24
@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

Copy link
Contributor

@pschuh pschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me!
If I understand correctly, this:

  • Moves the scope pop up to not include the emitApplyAllocatingInitializer
  • Fixes a bug where I wasn't cleaning up properly in the case of exceptions.
  • Removes the argument relabeling
  • Adds an optimization for [T] types.

@slavapestov slavapestov merged commit 7c7f60a into swiftlang:master Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants