Convert ArrayExpr to not use callWitness() or generate a SemanticExpr. #23618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
pschuh
approved these changes
Mar 28, 2019
There was a problem hiding this comment.
All looks good to me!
If I understand correctly, this:
- Moves the scope pop up to not include the emitApplyAllocatingInitializer
- Fixes a bug where I wasn't cleaning up properly in the case of exceptions.
- Removes the argument relabeling
- Adds an optimization for [T] types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on @pschuh's #23177. @pschuh did not have a Mac to test so I helped fix an issue specific to bridging conversions. See the original PR for motivation and review discussion.