Remove unnecessary 'visitDecl' default cases. #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default cases are unnecessary and provide no benefits so they should just be removed.
|
Have you run the test suite with this patch? |
|
It seems reasonable to remove this. |
DougGregor
added a commit
that referenced
this pull request
Jan 12, 2016
Remove unnecessary 'visitDecl' default cases.
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
Create a DISPATCH_PTR_SIZE macro and use it
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
Create a DISPATCH_PTR_SIZE macro and use it Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
adellibovi
pushed a commit
to adellibovi/swift
that referenced
this pull request
May 20, 2019
Fix a bug where a delimiting comma could exceed the line limit.
maldahleh
pushed a commit
to maldahleh/swift
that referenced
this pull request
Oct 26, 2020
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
Update GRDB.swift hash to build against 4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default cases are unnecessary and provide no benefits so they should
just be removed.