Address PR comments on return omission. #24546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
nate-chandler
force-pushed
the
nate/omit-return-pr-fixes
branch
from
4a486de to
09754a7
Compare
|
@swift-ci please smoke test |
slavapestov
reviewed
May 7, 2019
lib/Parse/ParseDecl.cpp
Outdated
| auto kind = AFD->getKind(); | ||
| if (kind == DeclKind::Var || kind == DeclKind::Subscript || | ||
| kind == DeclKind::Func ) { | ||
| if (isa<AccessorDecl>(AFD) || isa<FuncDecl>(AFD)) { |
There was a problem hiding this comment.
AccessorDecl is a subclass of FuncDecl so only the RHS of the || is needed.
slavapestov
approved these changes
May 7, 2019
nate-chandler
force-pushed
the
nate/omit-return-pr-fixes
branch
from
09754a7 to
1267f65
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses two issues identified by Slava in the already merged return omission PR.