Skip to content

[AutoDiff] [stdlib] Add JVP for 'differentiableReduce(_:_:)'. #29324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rxwei
Copy link
Contributor

@rxwei rxwei commented Jan 21, 2020

Add a JVP for differentiableReduce(_:_:).

Add a JVP for `differentiableReduce(_:_:)`.
@rxwei rxwei requested a review from dan-zheng January 21, 2020 06:20
@rxwei
Copy link
Contributor Author

rxwei commented Jan 21, 2020

Note: This is currently missing unit tests.

Copy link
Contributor

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with tests

@rxwei
Copy link
Contributor Author

rxwei commented Jan 21, 2020

I currently don't have the bandwidth to write unit tests. This is just upstreaming parts of this gist. If anyone wants to commit some unit tests that'd be appreciated!

@compnerd compnerd closed this Feb 22, 2020
@dan-zheng
Copy link
Contributor

I accidentally deleted tensorflow branch, which closed this PR. That was not intentional, sorry!
It would be nice to protect tensorflow branch against deletion to prevent this from happening again.

@dan-zheng dan-zheng reopened this Feb 22, 2020
efremale added a commit to efremale/swift that referenced this pull request Jul 11, 2020
dan-zheng pushed a commit that referenced this pull request Jul 12, 2020
Adds JVPs to `Array` and `Array.DifferentiableView`

`_jvpDifferentiableReduce` is taken from #29324
@dan-zheng
Copy link
Contributor

This PR was effectively cherry-picked into #32840. Thanks @rxwei for the original implementation!

@dan-zheng dan-zheng closed this Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants