[WebAssembly] enable shims and stubs for WASI #29505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested changes
Jan 28, 2020
stdlib/public/stubs/Random.cpp
Outdated
| @@ -42,6 +42,10 @@ | |||
| #include "swift/Runtime/Mutex.h" | |||
| #include "../SwiftShims/Random.h" | |||
|
|
|||
| #if defined(__wasi__) | |||
| #include <algorithm> // required for std::min | |||
| #endif | |||
There was a problem hiding this comment.
Just make this unconditional. This is inside the implementation, so it is fine.
stdlib/public/stubs/Stubs.cpp
Outdated
| @@ -511,6 +513,8 @@ void swift::_swift_stdlib_flockfile_stdout() { | |||
| void swift::_swift_stdlib_funlockfile_stdout() { | |||
| #if defined(_WIN32) | |||
| _unlock_file(stdout); | |||
| #elif defined(__wasi__) | |||
| // WebAssembly/WASI doesn't support file locking yet | |||
There was a problem hiding this comment.
Please create a JIRA issue for supporting threading/locking on WASI and reference it here.
|
@swift-ci please smoke test |
78 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
#if defined(__wasi__)instdlib/public/stubsand implements_swift_stdlib_getUnsafeArgvArgcto fix corresponding code when compiling for WASI.This is a part of SR-9307 and #24684.
(cc @kateinoigakukun)