Skip to content

[5.2]Revert: [SourceKit] Disable module system headers validation #29556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2020
Merged

[5.2]Revert: [SourceKit] Disable module system headers validation #29556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a7030b
Revert "[SourceKit] Disable module system headers validation"
rintaro Jan 30, 2020
062f953
Revert "[CodeCompletion] Disable module system headers validation"
rintaro Jan 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions tools/SourceKit/lib/SwiftLang/SwiftASTManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,11 +539,6 @@ bool SwiftASTManager::initCompilerInvocation(
// We don't care about LLVMArgs
FrontendOpts.LLVMArgs.clear();

// This validation may call stat(2) many times. Disable it to prevent
// performance issues.
Invocation.getSearchPathOptions().DisableModulesValidateSystemDependencies =
true;

// SwiftSourceInfo files provide source location information for decls coming
// from loaded modules. For most IDE use cases it either has an undesirable
// impact on performance with no benefit (code completion), results in stale
Expand Down
2 changes: 0 additions & 2 deletions tools/swift-ide-test/swift-ide-test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3302,8 +3302,6 @@ int main(int argc, char *argv[]) {
options::DebugForbidTypecheckPrefix;
InitInvok.getTypeCheckerOptions().DebugConstraintSolver =
options::DebugConstraintSolver;
InitInvok.getSearchPathOptions().DisableModulesValidateSystemDependencies =
true;

for (auto ConfigName : options::BuildConfigs)
InitInvok.getLangOptions().addCustomConditionalCompilationFlag(ConfigName);
Expand Down