[ownership] Get rid of old entrypoint for creatingEndBorrow that takes the original value. #29599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s the original value. The original design was to make it so that end_borrow tied at the use level its original/borrowed value. So we would have: ``` %borrowedVal = begin_borrow %original ... end_borrow %borrowedVal from %original ``` In the end we decided not to use that design and instead just use: ``` %borrowedVal = begin_borrow %original ... end_borrow %borrowedVal ``` In order to enable that transition, I left the old API for end_borrow that took both original and borrowedVal and reimplemented it on top of the new API that just took the borrowedVal (i.e. the original was just a dead arg). Now given where we are in the development, it makes sense to get rid of that transition API and move to just use the new API.
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original design was to make it so that end_borrow tied at the use level its
original/borrowed value. So we would have:
In the end we decided not to use that design and instead just use:
In order to enable that transition, I left the old API for end_borrow that took
both original and borrowedVal and reimplemented it on top of the new API that
just took the borrowedVal (i.e. the original was just a dead arg).
Now given where we are in the development, it makes sense to get rid of that
transition API and move to just use the new API.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.