SILGen: Relax assertion about missing vtable entries in a class #29726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
Since resilient class metadata is built at runtime, we don't actually care if there are missing vtable entries. The restriction was relaxed in Sema in 9117c57, but SILGen still had an assertion here. Add a test and relax the assertion. Fixes <rdar://problem/58644615>.
slavapestov
force-pushed
the
fix-silgen-vtable-assertion
branch
from
5ef6e6b to
fc810e1
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since resilient class metadata is built at runtime, we don't actually
care if there are missing vtable entries. The restriction was relaxed
in Sema in 9117c57, but SILGen still
had an assertion here.
Add a test and relax the assertion.
Fixes rdar://problem/58644615.