[CSDiagnostics] Offer a fix-it to insert a return type placeholder when returning from a void function #29747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from a void function
xedin
approved these changes
Feb 10, 2020
The function name will be empty in some cases, for example for property setters. In cases where the function name is empty, skip the note and fix-it.
|
@swift-ci please smoke test |
|
@theblixguy Let's hold off from triggering CI for now, it would have to be re-triggered after LLVM changes are done anyway. |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when we return from a
Void-returning function, an error is emitted:It's likely that the user forgot to add a return type, so add a fix-it to insert a placeholder for the type.