Revert "[ConstraintSystem] Make it possible to infer subtype bindings… #30283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… through argument conversions" Reverts swiftlang#30006. It caused a regression that we'd like to address before re-landing: ```swift struct X { var cgf: CGFloat } func test(x: X?) { let _ = (x?.cgf ?? 0) <= 0.5 } ``` This reverts commit 0a6b444. This reverts commit ed25559. This reverts commit 3e01160. This reverts commit 96297b7. Resolves: rdar://problem/60185506
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
I have also added a test-case to make sure that everything works correctly. |
Contributor
Author
|
I figured out what the problem is - while comparing bindings it check for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… through argument conversions"
Reverts #30006. It caused a regression that we'd like to address before re-landing:
This reverts commit 0a6b444.
This reverts commit ed25559.
This reverts commit 3e01160.
This reverts commit 96297b7.
Resolves: rdar://problem/60185506