Fix failing IRGen arm64e tests #30296
Conversation
|
@swift-ci smoke test |
kubamracek
force-pushed
the
mracek/arm64e-test-fixes
branch
from
2d15872 to
99d0e28
Compare
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
kubamracek
force-pushed
the
mracek/arm64e-test-fixes
branch
from
99d0e28 to
17cfb1b
Compare
|
@swift-ci smoke test |
kubamracek
force-pushed
the
mracek/arm64e-test-fixes
branch
from
17cfb1b to
a305879
Compare
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
kubamracek
force-pushed
the
mracek/arm64e-test-fixes
branch
from
a305879 to
70643f6
Compare
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
|
@kubamracek: seems that this change, which sets linux-gnu with an stable ABI for testing, might broke the Android tests (https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-16.04-android-arm64/3981). It seems that the code I am seeing generated might work with the stable ABI checks. Is it safe to put Android in that list of targets? (I can open the PR myself, but I want to double check that I am not doing something weird) |
|
Sorry for the late reply! The “stable ABI” applies only to platforms that ship Swift in the OS (Darwin), and on Linux we should be emitting the stable ABI version of code. If this broke a test, a PR would be great and I can take a look. |
See swiftlang#30391, swiftlang#30296. Neither IRGen/conditional_conformances.swift nor IRGen/class_resilience.swift pass on OpenBSD unless target_mandates_stable_abi = TRUE.
See swiftlang#30391, swiftlang#30296. Neither IRGen/conditional_conformances.swift nor IRGen/class_resilience.swift pass on OpenBSD unless target_mandates_stable_abi = TRUE.
No description provided.