[semantic-arc-opts] Follow ups to #30289 #30319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test and merge |
atrick
approved these changes
Mar 10, 2020
|
Yes. |
|
I was hoping to do the small ones here and the larger one that we talked about (the data structure change) in a separate commit. |
|
@swift-ci smoke test |
This is a clearer name. It is also corresponds with the function isOwnershipForwardingInst that classifies such operands.
We are checking the unknown consuming use vector, so the name makes this clearer and makes it clear we are not talking about destroying consumers. I also eliminated the phiToIncomingValueMultiMap being passed in favor of a bool argument since that is how we are using it today. That was a vestige of an earlier version of the patch that had to be sunk.
gottesmm
force-pushed
the
pr-9df4a4957e5ff72c67e090d3880070d8cd472328
branch
from
2524120 to
09cfcbf
Compare
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test linux platform |
1 similar comment
|
@swift-ci smoke test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some things that Andy and I agreed upon offline.