Partially revert "Keep gyb from messing up line endings on Windows" #30358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts most of commit 85599f7; it turns out the ‘b’ flag changes behavior more drastically in Python 3. Fixes SR-12328, rdar://problem/60230415.
Contributor
Author
|
@compnerd This shouldn't cause a regression on Windows because the test is still disabled, but I thought you'd want to know that I had to roll this back. |
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts most of commit 85599f7; it turns out the ‘b’ flag changes behavior more drastically in Python 3.
Fixes SR-12328, rdar://problem/60230415.