[OSLogOptimization] Fix folding of symbolic closures to handle @in_guaranteed captures #30386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new closures when all captures of the symbolic closure, including address-typed captures, are symbolic constants. For other closures, they must have been autoclosures passed to the log call and therefore they need not be duplicated but reused as such. This eliminates the need to copy_value the non-constant captured values of closures. Instead the closure itself is copied as a whole. Fixes <rdar://problem/60344043>
Contributor
Author
|
@swift-ci Please test and merge |
Contributor
Author
|
@swift-ci Please smoke test Linux Platform |
2 similar comments
Contributor
Author
|
@swift-ci Please smoke test Linux Platform |
Contributor
Author
|
@swift-ci Please smoke test Linux Platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the symbolic-closure folding code to create new closures only when all captures of the symbolic closure, including address-typed captures, are symbolic constants. In all other cases, the closure must be an autoclosure passed to the log call and therefore it need not be duplicated
and can be reused as such.
This eliminates the need to copy the non-constant captured values of
closures. Instead the closure itself is copied as a whole.
Fixes rdar://problem/60344043
cc @meg-gupta