[AutoDiff upstream] @differentiable function type sema #30648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcrasi
force-pushed
the
differentiable-function-type-sema
branch
from
c5ad526 to
e319d45
Compare
|
@swift-ci please test |
rxwei
approved these changes
Mar 26, 2020
marcrasi
force-pushed
the
differentiable-function-type-sema
branch
from
e319d45 to
b1b856b
Compare
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test osx |
|
Build failed |
|
@swift-ci Please smoke test macOS |
|
Merging to unblock progress. Smoke tests pass, full tests failed only due to CI outages earlier today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type checking for the
@differentiablefunction type:Differentiable.Differentiablewhen they are generic parameters.tensorflowbranch. (There are a few function conversion tests that I haven't imported because they depend on the function conversion pipeline.)Note: I needed to make a small logic change for this to work properly in
master. In thetensorflowbranch, we assume that theDifferentiableprotocol is always available. In themasterbranch, it is only available if youimport _Differentiation. So I changed all the places where we assert/segfault when theDifferentiableprotocol is missing to fail gracefully with a diagnostic. And I added a test for this.This resolves TF-823 and TF-1219.