Skip to content

test: repair the AutoDiff test on Windows #30907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
compnerd merged 1 commit into from
Apr 11, 2020
Merged

test: repair the AutoDiff test on Windows #30907

compnerd merged 1 commit into from
Apr 11, 2020

Conversation

@compnerd
Copy link
Member

@compnerd compnerd commented Apr 9, 2020

-lm is not portable, it is only needed on certain platforms (e.g.
Linux, not BSD). Remove the explicit link.

Avoid using a static library as that is not supported on all platforms
(e.g. Windows). Use the helper macros to generate the library.

Repairs the Windows tests.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

compnerd commented Apr 9, 2020

@swift-ci please test

@compnerd compnerd mentioned this pull request Apr 9, 2020
Closed
@compnerd
Copy link
Member Author

compnerd commented Apr 9, 2020

Windows failure is known (#30905)

@swift-ci
Copy link
Contributor

swift-ci commented Apr 9, 2020

Build failed
Swift Test Linux Platform
Git Sha - 7ac8bfe4f27f1a61738182d9ebddce21988a7d5b

@swift-ci
Copy link
Contributor

swift-ci commented Apr 9, 2020

Build failed
Swift Test OS X Platform
Git Sha - 7ac8bfe4f27f1a61738182d9ebddce21988a7d5b

@compnerd
Copy link
Member Author

compnerd commented Apr 9, 2020

@swift-ci please test

1 similar comment
@compnerd
Copy link
Member Author

compnerd commented Apr 9, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 9, 2020

Build failed
Swift Test Linux Platform
Git Sha - e2f0baae651a41bd3a37391f961551ae7c8330a1

@swift-ci
Copy link
Contributor

swift-ci commented Apr 9, 2020

Build failed
Swift Test OS X Platform
Git Sha - e2f0baae651a41bd3a37391f961551ae7c8330a1

@compnerd
Copy link
Member Author

compnerd commented Apr 9, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 9, 2020

Build failed
Swift Test Linux Platform
Git Sha - e2f0baae651a41bd3a37391f961551ae7c8330a1

@swift-ci
Copy link
Contributor

swift-ci commented Apr 9, 2020

Build failed
Swift Test OS X Platform
Git Sha - e2f0baae651a41bd3a37391f961551ae7c8330a1

@compnerd
Copy link
Member Author

compnerd commented Apr 9, 2020

@swift-ci please test Linux platform

@compnerd
Copy link
Member Author

compnerd commented Apr 9, 2020

@swift-ci please test Windows platform

@swift-ci
Copy link
Contributor

swift-ci commented Apr 9, 2020

Build failed
Swift Test Linux Platform
Git Sha - 55e048314a7c7171d37b72e3a20cd5dfc0e789b5

@compnerd
Copy link
Member Author

compnerd commented Apr 9, 2020

@swift-ci please clean test Linux platform

@swift-ci
Copy link
Contributor

swift-ci commented Apr 9, 2020

Build failed
Swift Test Linux Platform
Git Sha - 55e048314a7c7171d37b72e3a20cd5dfc0e789b5

@compnerd
Copy link
Member Author

compnerd commented Apr 10, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 10, 2020

Build failed
Swift Test OS X Platform
Git Sha - a33128dacf0c71e5820e01b724338e2f991de738

@swift-ci
Copy link
Contributor

swift-ci commented Apr 10, 2020

Build failed
Swift Test Linux Platform
Git Sha - a33128dacf0c71e5820e01b724338e2f991de738

@compnerd
Copy link
Member Author

compnerd commented Apr 10, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 10, 2020

Build failed
Swift Test OS X Platform
Git Sha - a33128dacf0c71e5820e01b724338e2f991de738

@compnerd
test: repair the AutoDiff test on Windows
de9aa59 
`-lm` is not portable, it is only needed on certain platforms (e.g.
Linux, not BSD).  Remove the explicit link.

Avoid using a static library as that is not supported on all platforms
(e.g. Windows).  Use the helper macros to generate the library.

Repairs the Windows tests.
@compnerd
Copy link
Member Author

compnerd commented Apr 10, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 10, 2020

Build failed
Swift Test Linux Platform
Git Sha - a33128dacf0c71e5820e01b724338e2f991de738

@swift-ci
Copy link
Contributor

swift-ci commented Apr 10, 2020

Build failed
Swift Test OS X Platform
Git Sha - a33128dacf0c71e5820e01b724338e2f991de738

@compnerd
Copy link
Member Author

compnerd commented Apr 10, 2020

@swift-ci please test Linux platform

@compnerd compnerd merged commit 3a8eea4 into swiftlang:master Apr 11, 2020
@compnerd compnerd deleted the autodiff-fix branch April 11, 2020 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dan-zheng dan-zheng dan-zheng approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@compnerd @swift-ci @dan-zheng