IRGen: Fix enumPayload value witness emission for huge types #31918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM's isel does not like integer types beyond a certain size (llvm::IntegerType::MAX_INT_BITS). rdar://63189452
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
compnerd
reviewed
May 20, 2020
test/IRGen/huge_c_type.swift
Outdated
| // llvm::IntegerTypes. | ||
| // RUN: %target-swift-frontend -import-objc-header %S/Inputs/huge_c_type.h %s -c | ||
|
|
||
| // REQUIRES: OS=macosx || OS=ios |
There was a problem hiding this comment.
What makes this test iOS/macOS specific? It seems that this test could be run on any target.
There was a problem hiding this comment.
See the first failure. It wants some module imported for size_t.
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test windows |
|
Oops, I thought I'd caught all the places we use large integer types in enums. Thanks for tracking this down! |
jckarter
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM's isel does not like integer types beyond a certain size
(llvm::IntegerType::MAX_INT_BITS).
rdar://63189452