Skip to content

[CodeCompletion] Handle variadic parameter in expr context analysis #31932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2020

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented May 21, 2020

for call arguments. Consider variadic arguments 'skippable'. Also, don't treat VarargExpansionExpr as a "context providing" expression.

rdar://problem/62479469

for call arguments. Consider variadic arguments 'skippable'. Also, don't
treat 'VarargExpansionExpr' as a "context providing" expression.

rdar://problem/62479469
@rintaro
Copy link
Member Author

rintaro commented May 21, 2020

@swift-ci Please smoke test

@rintaro rintaro requested a review from nathawes May 21, 2020 16:17
Copy link
Contributor

@nathawes nathawes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rintaro rintaro merged commit 6175c90 into swiftlang:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants