SIL: Verify kinds of vtable entries. #32171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate that inherited entries are not left at "normal" state, and that non-overridden entries do not in fact have overrides.
|
@swift-ci Please test |
gottesmm
reviewed
Jun 4, 2020
| validKind = false; | ||
| break; | ||
| } | ||
| assert(validKind && "vtable entry in root class must not be inherited or override"); |
There was a problem hiding this comment.
continue and eliminate the else? E.x.:
if (...) {
assert(validKind, ...)
continue;
}
if (superVTable) {
...
}
There was a problem hiding this comment.
The reason why I am suggesting this is that it makes it clearer that the if statement will never cause any code beneath it to be evaluated. Without this, I have to scan after the else if to see if that code may be run after the first if completes. In contrast, with the early continue like this I now have a nice invariant I can use when scanning the code below. Take it or leave it ; ).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate that inherited entries are not left at "normal" state, and that non-overridden entries do not in fact have overrides.