[memory-lifetime] Teach the verifier that select_enum_addr doesn't write to memory. #32177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ite to memory. This is an older verifier that checks that uses of addresses from things like in_guaranteed parameters are never written to. We just never hit this before. <rdar://problem/63188699>
|
@swift-ci test |
|
This is a pretty simple patch. Basically I am fixing this here and then onto 5.3. So whomever reviews this, please be aware that I want to cherry-pick this to 5.3, so I would also like to use you as my CCC reviewer. Not sure why we haven't hit it until now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an older verifier that checks that uses of addresses from things like
in_guaranteed parameters are never written to. We just never hit this before.
rdar://problem/63188699