Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Test C++ out-of-line operator functions" #32181

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Revert "Test C++ out-of-line operator functions" #32181

merged 1 commit into from
Jun 4, 2020

Conversation

MForster
Copy link
Contributor

@MForster MForster commented Jun 4, 2020

Reverts #32081

Interop/Cxx/operators/non-member-out-of-line-irgen.swift fails on armv7 on this bot https://ci.swift.org/job/oss-swift_tools-RA_stdlib-DA_test-device-non_executable/104

@MForster MForster added the c++ interop Feature: Interoperability with C++ label Jun 4, 2020
@MForster MForster requested a review from aschwaighofer June 4, 2020 14:50
@MForster MForster self-assigned this Jun 4, 2020
@MForster
Copy link
Contributor Author

MForster commented Jun 4, 2020

@swift-ci Please smoke test

aschwaighofer
aschwaighofer approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@MForster MForster merged commit e5e34fa into master Jun 4, 2020
@MForster MForster deleted the revert-32081-m/op/out-of-line branch June 4, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschwaighofer aschwaighofer aschwaighofer approved these changes

Assignees

@MForster MForster

Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MForster @aschwaighofer