[Parse] Avoid delayed member parsing for type decl with missing brace #32191
Conversation
Cache empty member list so that 'IterableDeclContext::loadAllMembers()' doesn't perform delayed member parsing. Fixes: rdar://problem/63921896
|
@swift-ci Please smoke test |
| LBLoc = RBLoc = PreviousLoc; | ||
|
|
||
| // Cache the empty result to prevent delayed parsing. | ||
| Context.evaluator.cacheOutput( |
There was a problem hiding this comment.
Why don't we change the evaluator to handle this rather than poking the result into the cache? This currently depends on the cache not really being a cache, but instead global mutable state.
The refactoring of parseMemberDeclList still seems like a readability win to me though.
There was a problem hiding this comment.
Although we can use getBrace().Start == getBrace().End as the indicator of "missing member brace", I thought it's a little brittle.
I implement it like this because "eager member parsing" is doing cacheOutput() as well.
https://github.com/apple/swift/blob/09ea5fd1f7fd61ed2ce8be380f1efc3c120a5ba6/lib/Parse/ParseDecl.cpp#L4441-L4458
There was a problem hiding this comment.
I see. I guess this doesn't make it worse in that case.
Cache empty member list so that 'IterableDeclContext::loadAllMembers()'
doesn't perform delayed member parsing.
Fixes: rdar://problem/63921896