AST: Add more asserts for same-type constraints in generic signatures #32666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please test source compatibility |
Contributor
Author
|
This caught a bug where we build an invalid minimized signature for the following: |
Contributor
Author
|
@swift-ci Please test source compatibility Debug |
Contributor
Author
|
That's funny, SRP in the source compat suite includes a copy of test/Prototypes/BigInt.swift, so it hits the same exact error. |
slavapestov
force-pushed
the
same-type-requirement-assert
branch
from
41c28fb to
844ab50
Compare
Contributor
Author
|
@swift-ci Please smoke test |
Member
|
This seems to have caused a regression on the Windows builder. This was caught by the precommit testing and the CI builds as well: https://ci-external.swift.org/job/oss-swift-windows-x86_64-vs2019/1918/ Could you please take a look at this @slavapestov? (seems that the test is passing on Windows?) |
This was referenced Jul 2, 2020
compnerd
added a commit
to compnerd/apple-swift
that referenced
this pull request
Jul 2, 2020
Adjust the test to fail properly
compnerd
added a commit
that referenced
this pull request
Jul 3, 2020
test: repair the Windows builders after #32666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.