Skip to content

Conversation

efremale
Copy link
Contributor

@efremale efremale commented Jul 8, 2020

Add a JVP for 'differentiableMap(_:)'.

@efremale efremale marked this pull request as draft July 8, 2020 23:31
@efremale efremale marked this pull request as ready for review July 8, 2020 23:31
Copy link
Contributor

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I left some minor comments related to Swift style.

@dan-zheng
Copy link
Contributor

cc @marcrasi @rxwei

@efremale
Copy link
Contributor Author

Fixed the suggested things in the code style!

@efremale efremale requested a review from dan-zheng July 10, 2020 12:47
@dan-zheng
Copy link
Contributor

@swift-ci Please smoke test

@efremale
Copy link
Contributor Author

(Not sure if the test is passing now -- lit fails with Aborted (core dumped) ... a.out at some point for me)

@dan-zheng
Copy link
Contributor

@swift-ci Please smoke test

@efremale
Copy link
Contributor Author

@dan-zheng should we close this since #32854 was merged?

@dan-zheng
Copy link
Contributor

Yes, thanks - this PR should be closed because it's subsumed by #32840.

@dan-zheng dan-zheng closed this Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants