[AutoDiff] Conform Optional to Differentiable.
#32948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `Optional` conditionally conform to `Differentiable` when the `Wrapped` type does. `Optional.TangentVector` is a wrapper around `Wrapped.TangentVector?`. Also, fix `Array.TangentVector.zeroTangentVectorInitializer`. Resolves TF-1301.
|
cc @efremale |
rxwei
reviewed
Jul 17, 2020
rxwei
approved these changes
Jul 17, 2020
dan-zheng
commented
Jul 17, 2020
| } | ||
|
|
||
| public static var zero: Self { | ||
| return Self(.zero) |
There was a problem hiding this comment.
Note: it seems more efficient to use Optional.TangentVector(nil) as Optional.TangentVector.zero. We can explore the implications when working on differentiation support for Optional.
|
@swift-ci Please smoke test |
|
We are seeing build failure on Swift CI, it might be related to this change. https://ci.swift.org/job/oss-swift-package-linux-ubuntu-16_04/5328/console |
|
Sorry about the test failure! I created #32981 to disable the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
Optionalconditionally conform toDifferentiablewhen theWrappedtype does.Optional.TangentVectoris a wrapper aroundWrapped.TangentVector?, following the design in the Differentiable Programming Manifesto.Also, fix
Array.TangentVector.zeroTangentVectorInitializer.Resolves TF-1301.
Stepping stone towards differentiation support of optional-related operations: TF-1153.