Skip to content

Drop Legacy Cascading Dependencies From the Frontend #33096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CodaFi merged 16 commits into from
Sep 21, 2020
Merged

Drop Legacy Cascading Dependencies From the Frontend #33096

CodaFi merged 16 commits into from
Sep 21, 2020

Conversation

@CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Jul 24, 2020

It's been a long time coming.

@CodaFi
Copy link
Contributor Author

CodaFi commented Jul 24, 2020

@swift-ci test

@CodaFi
Copy link
Contributor Author

CodaFi commented Jul 24, 2020

@swift-ci test source compatibility

@CodaFi
Copy link
Contributor Author

CodaFi commented Jul 24, 2020

@swift-ci test compiler performance

@swiftlang swiftlang deleted a comment from swift-ci Jul 24, 2020
@swiftlang swiftlang deleted a comment from swift-ci Jul 24, 2020
davidungar
davidungar approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@davidungar davidungar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@swiftlang swiftlang deleted a comment from swift-ci Jul 24, 2020
@CodaFi
Copy link
Contributor Author

CodaFi commented Jul 24, 2020

Saving a link to the pre-primary compiler perf run

@CodaFi CodaFi force-pushed the my-private-eyes branch from 07b09b0 to eb57648 Compare July 24, 2020 23:49
@CodaFi
Copy link
Contributor Author

CodaFi commented Jul 24, 2020

@swift-ci smoke test

@CodaFi
Copy link
Contributor Author

CodaFi commented Jul 24, 2020

@swift-ci test compiler performance

@swiftlang swiftlang deleted a comment from swift-ci Jul 25, 2020
@swiftlang swiftlang deleted a comment from swift-ci Jul 25, 2020
@CodaFi
Copy link
Contributor Author

CodaFi commented Jul 26, 2020 •
edited
Loading

These numbers make no sense. No way this PR cuts 90% of wall time alone, we just failed an enormous amount of projects because of infrastructure issues.

@swift-ci test compiler performance

@swiftlang swiftlang deleted a comment from swift-ci Jul 26, 2020
@swift-ci
Copy link
Contributor

swift-ci commented Jul 27, 2020

Summary for master full

Unexpected test results, excluded stats for RxCocoa, Backend

No regressions above thresholds

Debug-batch

debug-batch brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 83,732,351,827,568 83,625,867,152,981 -106,484,674,587 -0.13%
LLVM.NumLLVMBytesOutput 1,599,095,596 1,599,092,440 -3,156 -0.0%
time.swift-driver.wall 6276.6s 6284.0s 7.4s 0.12%

debug-batch detailed

Regressed (0)
name old new delta delta_pct
Improved (2)
name old new delta delta_pct
Driver.NumDriverPipePolls 90,427 88,978 -1,449 -1.6% ✅
Driver.NumDriverPipeReads 82,284 80,775 -1,509 -1.83% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (243)
name old new delta delta_pct
AST.ImportSetCacheHit 1,676,951 1,676,863 -88 -0.01%
AST.ImportSetCacheMiss 381,247 381,251 4 0.0%
AST.ImportSetFoldHit 126,963 126,961 -2 -0.0%
AST.ImportSetFoldMiss 254,283 254,290 7 0.0%
AST.ModuleShadowCacheHit 3,032 3,032 0 0.0%
AST.ModuleShadowCacheMiss 1,337 1,337 0 0.0%
AST.ModuleVisibilityCacheHit 35,142 35,142 0 0.0%
AST.ModuleVisibilityCacheMiss 8,444 8,444 0 0.0%
AST.NumASTBytesAllocated 37,408,158,300 37,431,595,803 23,437,503 0.06%
AST.NumASTScopeLookups 3,385,257 3,385,312 55 0.0%
AST.NumBraceStmtASTScopeExpansions 545,701 545,701 0 0.0%
AST.NumBraceStmtASTScopes 545,701 545,701 0 0.0%
AST.NumDecls 122,048 122,048 0 0.0%
AST.NumDependencies 251,234 251,141 -93 -0.04%
AST.NumIterableTypeBodyASTScopeExpansions 221,336 221,336 0 0.0%
AST.NumIterableTypeBodyASTScopes 269,126 269,134 8 0.0%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 220,752 220,752 0 0.0%
AST.NumLocalTypeDecls 254 254 0 0.0%
AST.NumModuleLookupClassMember 7,008 7,008 0 0.0%
AST.NumModuleLookupValue 46,343,627 46,341,303 -2,324 -0.01%
AST.NumObjCMethods 24,768 24,768 0 0.0%
AST.NumOperators 683 683 0 0.0%
AST.NumPrecedenceGroups 122 122 0 0.0%
AST.NumReferencedDynamicNames 188 188 0 0.0%
AST.NumReferencedMemberNames 7,920,747 7,920,410 -337 -0.0%
AST.NumReferencedTopLevelNames 853,409 853,409 0 0.0%
AST.NumSourceBuffers 351,561 351,561 0 0.0%
AST.NumSourceLines 4,198,007 4,198,007 0 0.0%
AST.NumSourceLinesPerSecond 1,594,830 1,596,439 1,609 0.1%
AST.NumTotalClangImportedEntities 1,808,616 1,809,178 562 0.03%
Driver.ChildrenMaxRSS 184,189,083,648 183,639,662,592 -549,421,056 -0.3%
Driver.DriverDepCascadingDynamic 0 0 0 0.0%
Driver.DriverDepCascadingExternal 0 0 0 0.0%
Driver.DriverDepCascadingMember 0 0 0 0.0%
Driver.DriverDepCascadingNominal 0 0 0 0.0%
Driver.DriverDepCascadingTopLevel 0 0 0 0.0%
Driver.DriverDepDynamic 0 0 0 0.0%
Driver.DriverDepExternal 0 0 0 0.0%
Driver.DriverDepMember 0 0 0 0.0%
Driver.DriverDepNominal 0 0 0 0.0%
Driver.DriverDepTopLevel 0 0 0 0.0%
Driver.NumDriverJobsRun 24,308 24,308 0 0.0%
Driver.NumDriverJobsSkipped 0 0 0 0.0%
Driver.NumProcessFailures 0 0 0 0.0%
Frontend.MaxMallocUsage 944,983,434,296 942,619,617,688 -2,363,816,608 -0.25%
Frontend.NumInstructionsExecuted 83,732,351,827,568 83,625,867,152,981 -106,484,674,587 -0.13%
Frontend.NumProcessFailures 0 0 0 0.0%
IRGen.IRGenRequest 23,262 23,262 0 0.0%
IRGen.OptimizedIRRequest 0 0 0 0.0%
IRModule.NumGOTEntries 193,950 193,950 0 0.0%
IRModule.NumIRAliases 177,131 177,131 0 0.0%
IRModule.NumIRBasicBlocks 5,946,922 5,946,922 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 2,990,223 2,990,223 0 0.0%
IRModule.NumIRGlobals 3,310,011 3,310,011 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 79,475,814 79,475,814 0 0.0%
IRModule.NumIRNamedMetaData 117,910 117,910 0 0.0%
IRModule.NumIRValueSymbols 5,752,880 5,752,880 0 0.0%
LLVM.NumLLVMBytesOutput 1,599,095,596 1,599,092,440 -3,156 -0.0%
Parse.CodeCompletionSecondPassRequest 0 0 0 0.0%
Parse.NumFunctionsParsed 241,375 241,375 0 0.0%
Parse.NumIterableDeclContextParsed 653,872 653,873 1 0.0%
Parse.ParseAbstractFunctionBodyRequest 220,171 220,171 0 0.0%
Parse.ParseMembersRequest 529,131 529,132 1 0.0%
Parse.ParseSourceFileRequest 348,396 348,396 0 0.0%
SILGen.ASTLoweringRequest 24,303 24,303 0 0.0%
SILGen.ParseSILModuleRequest 0 0 0 0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 1,838,892 1,838,892 0 0.0%
SILModule.NumSILGenGlobalVariables 46,241 46,241 0 0.0%
SILModule.NumSILGenVtables 29,036 29,036 0 0.0%
SILModule.NumSILGenWitnessTables 108,056 108,056 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 2,189,144 2,189,144 0 0.0%
SILModule.NumSILOptGlobalVariables 47,335 47,335 0 0.0%
SILModule.NumSILOptVtables 29,090 29,090 0 0.0%
SILModule.NumSILOptWitnessTables 139,403 139,403 0 0.0%
SILOptimizer.ExecuteSILPipelineRequest 94,149 94,149 0 0.0%
Sema.AbstractGenericSignatureRequest 34,627 34,627 0 0.0%
Sema.AccessLevelRequest 11,377,447 11,401,541 24,094 0.21%
Sema.AnyObjectLookupRequest 276 276 0 0.0%
Sema.AreAllStoredPropertiesDefaultInitableRequest 21,420 21,420 0 0.0%
Sema.AttachedFunctionBuilderRequest 304,293 304,293 0 0.0%
Sema.AttachedPropertyWrapperTypeRequest 499,636 499,636 0 0.0%
Sema.AttachedPropertyWrappersRequest 2,345,296 2,345,296 0 0.0%
Sema.CallerSideDefaultArgExprRequest 58,801 58,801 0 0.0%
Sema.CheckInconsistentImplementationOnlyImportsRequest 8,262 8,262 0 0.0%
Sema.CheckRedeclarationRequest 860,022 860,022 0 0.0%
Sema.ClassAncestryFlagsRequest 98,799 98,799 0 0.0%
Sema.ClosureHasExplicitResultRequest 78,705 78,705 0 0.0%
Sema.CodeCompletionFileRequest 0 0 0 0.0%
Sema.CollectOverriddenDeclsRequest 6,846,226 6,862,674 16,448 0.24%
Sema.CompareDeclSpecializationRequest 405,563 405,588 25 0.01%
Sema.CursorInfoRequest 0 0 0 0.0%
Sema.CustomAttrNominalRequest 536 536 0 0.0%
Sema.CustomAttrTypeRequest 333 333 0 0.0%
Sema.DefaultAndMaxAccessLevelRequest 50,169 50,169 0 0.0%
Sema.DefaultArgumentExprRequest 35,228 35,228 0 0.0%
Sema.DefaultArgumentInitContextRequest 210 210 0 0.0%
Sema.DefaultDefinitionTypeRequest 5,336 5,336 0 0.0%
Sema.DefaultTypeRequest 331,783 331,783 0 0.0%
Sema.DerivativeAttrOriginalDeclRequest 0 0 0 0.0%
Sema.DifferentiableAttributeTypeCheckRequest 0 0 0 0.0%
Sema.DirectLookupRequest 30,599,514 30,606,419 6,905 0.02%
Sema.DirectOperatorLookupRequest 1,696,770 1,696,695 -75 -0.0%
Sema.DirectPrecedenceGroupLookupRequest 554,172 554,172 0 0.0%
Sema.DynamicallyReplacedDeclRequest 938,435 938,435 0 0.0%
Sema.EmittedMembersRequest 24,990 24,990 0 0.0%
Sema.EnumRawTypeRequest 20,989 20,989 0 0.0%
Sema.EnumRawValuesRequest 9,503 9,503 0 0.0%
Sema.ExistentialConformsToSelfRequest 12,508 12,515 7 0.06%
Sema.ExistentialTypeSupportedRequest 14,384 14,384 0 0.0%
Sema.ExpandASTScopeRequest 6,200,544 6,200,552 8 0.0%
Sema.ExtendedNominalRequest 564,350 564,350 0 0.0%
Sema.ExtendedTypeRequest 72,291 72,291 0 0.0%
Sema.FragileFunctionKindRequest 1,575,729 1,575,729 0 0.0%
Sema.FunctionBuilderTypeRequest 303,917 303,917 0 0.0%
Sema.FunctionOperatorRequest 53,402 53,402 0 0.0%
Sema.GenericParamListRequest 8,374,239 8,386,943 12,704 0.15%
Sema.GenericSignatureRequest 2,149,618 2,149,765 147 0.01%
Sema.GetDestructorRequest 25,579 25,579 0 0.0%
Sema.HasCircularInheritanceRequest 21,616 21,616 0 0.0%
Sema.HasCircularInheritedProtocolsRequest 8,589 8,589 0 0.0%
Sema.HasCircularRawValueRequest 7,662 7,662 0 0.0%
Sema.HasDefaultInitRequest 48,255 48,255 0 0.0%
Sema.HasDynamicCallableAttributeRequest 0 0 0 0.0%
Sema.HasDynamicMemberLookupAttributeRequest 532,420 532,479 59 0.01%
Sema.HasImplementationOnlyImportsRequest 348,396 348,396 0 0.0%
Sema.HasMemberwiseInitRequest 16,111 16,111 0 0.0%
Sema.HasMissingDesignatedInitializersRequest 24,049 24,049 0 0.0%
Sema.HasUserDefinedDesignatedInitRequest 48,265 48,265 0 0.0%
Sema.InferredGenericSignatureRequest 161,565 161,565 0 0.0%
Sema.InheritedDeclsReferencedRequest 4,858,790 4,861,271 2,481 0.05%
Sema.InheritedProtocolsRequest 497,903 497,937 34 0.01%
Sema.InheritedTypeRequest 270,472 270,423 -49 -0.02%
Sema.InheritsSuperclassInitializersRequest 26,946 26,946 0 0.0%
Sema.InitKindRequest 85,885 85,885 0 0.0%
Sema.InterfaceTypeRequest 12,243,226 12,256,226 13,000 0.11%
Sema.IsABICompatibleOverrideRequest 121,923 121,923 0 0.0%
Sema.IsAccessorTransparentRequest 282,692 282,692 0 0.0%
Sema.IsCallableNominalTypeRequest 1,638 1,638 0 0.0%
Sema.IsDeclApplicableRequest 0 0 0 0.0%
Sema.IsDynamicRequest 1,498,646 1,498,646 0 0.0%
Sema.IsFinalRequest 2,413,377 2,414,829 1,452 0.06%
Sema.IsGetterMutatingRequest 376,400 376,400 0 0.0%
Sema.IsImplicitlyUnwrappedOptionalRequest 2,104,201 2,104,356 155 0.01%
Sema.IsObjCRequest 1,362,229 1,362,477 248 0.02%
Sema.IsSetterMutatingRequest 318,825 318,825 0 0.0%
Sema.IsStaticRequest 818,914 818,937 23 0.0%
Sema.LazyStoragePropertyRequest 2,566 2,566 0 0.0%
Sema.LookupAllConformancesInContextRequest 72,223 72,223 0 0.0%
Sema.LookupConformanceInModuleRequest 35,775,402 35,783,336 7,934 0.02%
Sema.LookupInModuleRequest 5,737,604 5,735,101 -2,503 -0.04%
Sema.LookupInfixOperatorRequest 68,495 68,495 0 0.0%
Sema.LookupPostfixOperatorRequest 186 186 0 0.0%
Sema.LookupPrecedenceGroupRequest 24,099 24,099 0 0.0%
Sema.LookupPrefixOperatorRequest 738 738 0 0.0%
Sema.MangleLocalTypeDeclRequest 508 508 0 0.0%
Sema.ModuleImplicitImportsRequest 9,283 9,283 0 0.0%
Sema.ModuleQualifiedLookupRequest 2,619,963 2,617,404 -2,559 -0.1%
Sema.NamedLazyMemberLoadSuccessCount 18,790,584 18,790,690 106 0.0%
Sema.NamingPatternRequest 192,311 192,311 0 0.0%
Sema.NeedsNewVTableEntryRequest 616,920 616,920 0 0.0%
Sema.NumAccessorBodiesSynthesized 166,606 166,606 0 0.0%
Sema.NumAccessorsSynthesized 260,634 260,634 0 0.0%
Sema.NumConformancesDeserialized 7,990,959 8,000,331 9,372 0.12%
Sema.NumConstraintScopes 27,974,736 27,975,551 815 0.0%
Sema.NumConstraintsConsideredForEdgeContraction 86,235,384 86,235,579 195 0.0%
Sema.NumCrossImportsChecked 0 0 0 0.0%
Sema.NumCrossImportsFound 0 0 0 0.0%
Sema.NumCyclicOneWayComponentsCollapsed 346 346 0 0.0%
Sema.NumDeclsDeserialized 63,959,393 64,015,978 56,585 0.09%
Sema.NumDeclsTypechecked 1,239,296 1,239,296 0 0.0%
Sema.NumGenericSignatureBuilders 1,027,710 1,028,690 980 0.1%
Sema.NumLazyIterableDeclContexts 7,520,425 7,523,405 2,980 0.04%
Sema.NumLazyRequirementSignatures 716,177 716,354 177 0.02%
Sema.NumLazyRequirementSignaturesLoaded 492,776 492,912 136 0.03%
Sema.NumLeafScopes 17,496,310 17,497,049 739 0.0%
Sema.NumTypesDeserialized 19,951,426 19,965,106 13,680 0.07%
Sema.NumUnloadedLazyIterableDeclContexts 4,724,935 4,724,029 -906 -0.02%
Sema.OpaqueReadOwnershipRequest 249,538 249,538 0 0.0%
Sema.OpaqueResultTypeRequest 204 204 0 0.0%
Sema.OperatorPrecedenceGroupRequest 784 784 0 0.0%
Sema.OverriddenDeclsRequest 2,232,102 2,234,906 2,804 0.13%
Sema.ParamSpecifierRequest 1,106,787 1,106,787 0 0.0%
Sema.PatternBindingEntryRequest 408,398 408,398 0 0.0%
Sema.PatternTypeRequest 473,354 473,354 0 0.0%
Sema.PreCheckFunctionBuilderRequest 330 330 0 0.0%
Sema.PrimarySourceFilesRequest 9,283 9,283 0 0.0%
Sema.PropertyWrapperBackingPropertyInfoRequest 494,072 494,072 0 0.0%
Sema.PropertyWrapperBackingPropertyTypeRequest 499,636 499,636 0 0.0%
Sema.PropertyWrapperLValuenessRequest 264 264 0 0.0%
Sema.PropertyWrapperMutabilityRequest 532,321 532,321 0 0.0%
Sema.PropertyWrapperTypeInfoRequest 100 100 0 0.0%
Sema.ProtocolRequiresClassRequest 35,251 35,221 -30 -0.09%
Sema.ProvideDefaultImplForRequest 6,846,226 6,862,674 16,448 0.24%
Sema.QualifiedLookupRequest 4,852,508 4,854,299 1,791 0.04%
Sema.RangeInfoRequest 0 0 0 0.0%
Sema.RequirementRequest 107,272 107,272 0 0.0%
Sema.RequirementSignatureRequest 544,269 544,357 88 0.02%
Sema.RequiresOpaqueAccessorsRequest 1,157,933 1,157,933 0 0.0%
Sema.RequiresOpaqueModifyCoroutineRequest 235,733 235,733 0 0.0%
Sema.ResolveEffectiveMemberwiseInitRequest 0 0 0 0.0%
Sema.ResolveImplicitMemberRequest 365,498 365,663 165 0.05%
Sema.ResolveProtocolNameRequest 0 0 0 0.0%
Sema.ResolveTypeEraserTypeRequest 0 0 0 0.0%
Sema.ResolveTypeRequest 3,125,605 3,125,605 0 0.0%
Sema.ResultTypeRequest 585,907 585,907 0 0.0%
Sema.RootAndResultTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.RootTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.SPIGroupsRequest 11,764,280 11,782,608 18,328 0.16%
Sema.ScopedImportLookupRequest 996 996 0 0.0%
Sema.SelfAccessKindRequest 566,475 566,493 18 0.0%
Sema.SelfBoundsFromWhereClauseRequest 1,579,049 1,578,656 -393 -0.02%
Sema.SetterAccessLevelRequest 125,597 125,597 0 0.0%
Sema.SimpleDidSetRequest 2,219,736 2,223,072 3,336 0.15%
Sema.StorageImplInfoRequest 1,268,587 1,268,587 0 0.0%
Sema.StoredPropertiesAndMissingMembersRequest 29,042 29,042 0 0.0%
Sema.StoredPropertiesRequest 287,687 287,687 0 0.0%
Sema.StructuralTypeRequest 1,496 1,496 0 0.0%
Sema.SuperclassDeclRequest 374,487 374,557 70 0.02%
Sema.SuperclassTypeRequest 50,798 50,798 0 0.0%
Sema.SynthesizeAccessorRequest 260,634 260,634 0 0.0%
Sema.SynthesizeDefaultInitRequest 4,755 4,755 0 0.0%
Sema.SynthesizeMainFunctionRequest 24,175 24,175 0 0.0%
Sema.SynthesizeMemberwiseInitRequest 3,020 3,020 0 0.0%
Sema.TangentStoredPropertyRequest 0 0 0 0.0%
Sema.TypeCheckFunctionBodyAtLocRequest 0 0 0 0.0%
Sema.TypeCheckFunctionBodyRequest 469,446 469,446 0 0.0%
Sema.TypeCheckSourceFileRequest 23,582 23,582 0 0.0%
Sema.TypeDeclsFromWhereClauseRequest 27,367 27,367 0 0.0%
Sema.TypeEraserHasViableInitRequest 0 0 0 0.0%
Sema.TypeRelationCheckRequest 0 0 0 0.0%
Sema.TypeWitnessRequest 8,201 8,201 0 0.0%
Sema.USRGenerationRequest 8,008,770 8,025,166 16,396 0.2%
Sema.UnderlyingTypeDeclsReferencedRequest 266,778 266,830 52 0.02%
Sema.UnderlyingTypeRequest 32,672 32,672 0 0.0%
Sema.UnqualifiedLookupRequest 3,511,448 3,511,503 55 0.0%
Sema.ValidatePrecedenceGroupRequest 158,614 158,614 0 0.0%
Sema.ValueWitnessRequest 58,206 58,206 0 0.0%
TBDGen.GenerateTBDRequest 23,282 23,282 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 50,635,896,111,556 50,594,057,795,726 -41,838,315,830 -0.08%
LLVM.NumLLVMBytesOutput 1,570,977,732 1,570,981,124 3,392 0.0%
time.swift-driver.wall 8657.1s 8667.2s 10.1s 0.12%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (16)
name old new delta delta_pct
AST.NumLoadedModules 21,335 21,335 0 0.0%
AST.NumTotalClangImportedEntities 431,387 431,387 0 0.0%
IRModule.NumIRBasicBlocks 4,005,542 4,005,542 0 0.0%
IRModule.NumIRFunctions 2,451,776 2,451,776 0 0.0%
IRModule.NumIRGlobals 2,955,117 2,955,117 0 0.0%
IRModule.NumIRInsts 42,131,719 42,131,719 0 0.0%
IRModule.NumIRValueSymbols 5,132,771 5,132,771 0 0.0%
LLVM.NumLLVMBytesOutput 1,570,977,732 1,570,981,124 3,392 0.0%
SILModule.NumSILGenFunctions 1,044,955 1,044,955 0 0.0%
SILModule.NumSILOptFunctions 884,562 884,562 0 0.0%
Sema.NumConformancesDeserialized 2,712,252 2,712,252 0 0.0%
Sema.NumConstraintScopes 28,401,684 28,401,684 0 0.0%
Sema.NumDeclsDeserialized 9,061,204 9,061,204 0 0.0%
Sema.NumGenericSignatureBuilders 198,392 198,392 0 0.0%
Sema.NumLazyIterableDeclContexts 1,147,407 1,147,407 0 0.0%
Sema.NumTypesDeserialized 4,344,148 4,344,148 0 0.0%

slavapestov
slavapestov approved these changes Jul 28, 2020
View reviewed changes
@CodaFi CodaFi force-pushed the my-private-eyes branch from eb57648 to 90e0d0c Compare July 28, 2020 17:29
@CodaFi
Copy link
Contributor Author

CodaFi commented Jul 28, 2020

@swift-ci smoke test

@CodaFi CodaFi force-pushed the my-private-eyes branch from 90e0d0c to 90fcaef Compare July 31, 2020 06:05
@CodaFi CodaFi force-pushed the my-private-eyes branch 3 times, most recently from df5b907 to 78d5d10 Compare August 19, 2020 20:23
CodaFi added 13 commits September 21, 2020 10:37
@CodaFi
Remove NLOptions::NL_Known*
7bee5ff
@CodaFi
Remove DeclContext::isCascadingContextForLookup
934f994
@CodaFi
Remove evaluator::getScopeForAccessLevel
3dd74c1
@CodaFi
Remove DependencyScope
7fb4480
@CodaFi
Remove Reference::cascades
9e7964f
@CodaFi
Remove unnecessary dependency sources
fe5dacb
@CodaFi
Remove Cascading Computations from ASTScope
d93c6d8
@CodaFi
Remove LegacyCascadingDependencies
8c913e3
@CodaFi
Remove appendHolderOfCascadingMembers
daeb081
@CodaFi
Remove DependencyRecorder::Mode
e37b378
@CodaFi
Drop Legacy Tests
78e78a2
@CodaFi
[NFC] Only Register Primaries As Dependency Sources
1b7c713 
Now that the top-level source file is the only dependency source that
matters, the only case that matters is when request evaluation enters
a primary file. For non-primaries, there will be no corresponding
swiftdeps file to emit references into, so we're just wasting time and
memory keeping track of anything that happens there.

This is only possible after we removed cascading dependencies because
unqualified lookups had to be charged to the files they originated in.
Now, we charge those lookups to the primary that initiated the request.
@CodaFi
Resolve ASTScope Issues
4557b69
@CodaFi CodaFi marked this pull request as ready for review September 21, 2020 17:07
@CodaFi
Copy link
Contributor Author

CodaFi commented Sep 21, 2020

@swift-ci test

@CodaFi
Copy link
Contributor Author

CodaFi commented Sep 21, 2020

@swift-ci test source compatibility

@CodaFi
Copy link
Contributor Author

CodaFi commented Sep 21, 2020

⛵

@CodaFi CodaFi merged commit 4d875ee into swiftlang:master Sep 21, 2020
@CodaFi CodaFi deleted the my-private-eyes branch September 21, 2020 20:05
@CodaFi CodaFi mentioned this pull request Sep 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slavapestov slavapestov slavapestov approved these changes

@DougGregor DougGregor Awaiting requested review from DougGregor

+1 more reviewer

@davidungar davidungar davidungar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CodaFi @swift-ci @slavapestov @davidungar