Mark main() as used #33197
Merged
Mark main() as used #33197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents dead code stripping from removing the main() function used in widgets. This special case was added to support the integrated REPL, which was removed after Swift 5.3, and so it is no longer necessary. Fixes rdar://65862827.
Contributor
Author
|
@swift-ci please test |
CodaFi
approved these changes
Jul 30, 2020
Contributor
|
@lhames Does ORC still manipulate the |
Contributor
|
ORC does not manipulate llvm.used, but ORC is only used in immediate mode at the moment, not in the REPL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents dead code stripping from removing the
main()function used in widgets. This special case was added to support the integrated REPL, which was removed after Swift 5.3, and so it is no longer necessary.This is basically just #33177, but with the special case for
IRGenOptions::IntegratedREPLremoved because the integrated REPL is dead as a doornail in master.Fixes rdar://65862827.