[Serialization] Look for cross-ref errors inside type errors #33271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In swiftlang#30614, we started consuming XRefNonLoadedModuleErrors while loading conformances, since a conformance to a type we cannot load usually indicates we're trying to load a protocol that was declared in an @_implementationOnly imported module. We should also consume TypeErrors that we see where the underlying reason is an XRefNonLoadedModuleError, since they're likely indicators of the same thing.
Contributor
Author
|
@swift-ci please test |
xymus
approved these changes
Aug 3, 2020
Contributor
xymus
left a comment
xymus
left a comment
There was a problem hiding this comment.
That makes a lot of sense. Thank you!
Contributor
|
Build failed |
Contributor
Author
|
LLDB test timed out... @swift-ci please test Linux |
Contributor
Author
|
@swift-ci please test Linux |
| static llvm::Error consumeErrorIfXRefNonLoadedModule(llvm::Error &&error) { | ||
| // Missing module errors are most likely caused by an | ||
| // implementation-only import hiding types and decls. | ||
| // rdar://problem/60291019 |
Contributor
There was a problem hiding this comment.
I think it's okay to add a radar number into the commit message, but in the code they are not useful to any Swift developers outside of Apple. I would just try to say as much as possible about the problem in the comment itself (which you already did!) and move the radar link into a footnote in the git commit message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #30614, we started consuming XRefNonLoadedModuleErrors while loading
conformances, since a conformance to a type we cannot load usually
indicates we're trying to load a protocol that was declared in an
@_implementationOnly imported module.
We should also consume TypeErrors that we see where the underlying reason
is an XRefNonLoadedModuleError, since they're likely indicators of the
same thing.