Skip to content

[5.3] [Preset] Source compat suite cross compile for macOS arm64 #33779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tkremenek merged 5 commits into from
Sep 3, 2020
Merged

[5.3] [Preset] Source compat suite cross compile for macOS arm64 #33779

tkremenek merged 5 commits into from
Sep 3, 2020

Conversation

@shahmishal
Copy link
Member

@shahmishal shahmishal commented Sep 3, 2020 •
edited
Loading

master PR - #33297

@shahmishal shahmishal requested a review from a team as a code owner September 3, 2020 04:17
@shahmishal
Copy link
Member Author

shahmishal commented Sep 3, 2020

@swift-ci test

@shahmishal
Copy link
Member Author

shahmishal commented Sep 3, 2020

@swift-ci Please test source compatibility

@shahmishal
[CMake] Remove a redundant and potentially incorrect check.
a4356ab 
There's a more robust check for which SDK to support already.
This also misses `arm64` as architecture.

(cherry picked from commit ca3d37f)
@shahmishal
Copy link
Member Author

shahmishal commented Sep 3, 2020

@swift-ci Please test source compatibility

@shahmishal
Copy link
Member Author

shahmishal commented Sep 3, 2020

@swift-ci test

@swift-ci
Copy link
Contributor

swift-ci commented Sep 3, 2020

Build failed
Swift Test OS X Platform
Git Sha - a4356ab

@tkremenek tkremenek merged commit 8a07bc2 into release/5.3 Sep 3, 2020
@tkremenek tkremenek deleted the shahmishal/5.3-source-compat-suite branch September 3, 2020 17:43
@AnthonyLatsis AnthonyLatsis added swift 5.3 🍒 release cherry pick Flag: Release branch cherry picks and removed r5.3 labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edymtt edymtt edymtt approved these changes

@tkremenek tkremenek tkremenek approved these changes

Assignees

No one assigned

Labels

🍒 release cherry pick Flag: Release branch cherry picks swift 5.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@shahmishal @swift-ci @edymtt @tkremenek @benrimmington @AnthonyLatsis