[5.3] Stop ReplaceOpaqueTypesWithUnderlyingTypes recursion if it hits a fixpoint #33880
+27
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…point. This can happen when a non-substitutable opaque type appears in structural position, such as the root of an associated type archetype. Fixes rdar://problem/67040429.
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
@swift-ci Please nominate |
tkremenek
approved these changes
Sep 10, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: The compiler would get stuck in an infinite loop when trying to substitute opaque types with associated types, such as
some Gesturein SwiftUI.Scope: Crash when trying to write custom
Gesturetypes in SwiftUI.Issue: rdar://problem/67040429
Reviewed by: @aschwaighofer
Risk: Low