[Type checker] Use DotSyntaxCallExpr consistently for instance members. #34019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building a curry thunk for unapplied references to instance methods, the type checker would build a CallExpr rather than a DotSyntaxCallExpr to work around various issues with source locations. Fix the underlying issues with source locations in DotSyntaxCallExpr so we can consistently build DotSyntaxCallExpr here, and assert that we don't do this again: * DotSyntaxCallExpr wasn't able to reason about having just one of its children having source location information; fix it. * @dynamicCallable support was passing the declaration source location for the call expression, which was nowhere in the expression itself. The above mistake was covering for this one.
Member
Author
|
@swift-ci smoke test |
Member
Author
|
@swift-ci please test source compatibility |
Member
Author
|
Windows issue is unrelated: |
slavapestov
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building a curry thunk for unapplied references to instance
methods, the type checker would build a
CallExprrather than aDotSyntaxCallExprto work around various issues with source locations.Fix the underlying issues with source locations in
DotSyntaxCallExprso we can consistently build
DotSyntaxCallExprhere, and assert thatwe don't do this again:
DotSyntaxCallExprwasn't able to reason about having just one of itschildren having source location information; fix it.
@dynamicCallablesupport was passing the declaration source locationfor the call expression, which was nowhere in the expression itself.
The above mistake was covering for this one.