AST: Refactor SelfReferenceKind in preparation for #33767 #34249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@swift-ci please smoke test |
slavapestov
approved these changes
Oct 11, 2020
AnthonyLatsis
force-pushed
the
selfrefkind-refactor
branch
from
cabfb36 to
21b1ab8
Compare
This will enable us to allow members containing references to Self or associated types only in covariant position to be used on an existential
AnthonyLatsis
force-pushed
the
selfrefkind-refactor
branch
from
21b1ab8 to
4ee517f
Compare
Collaborator
Author
|
@swift-ci please smoke test |
Collaborator
Author
|
@swift-ci please test source compatibility release |
Collaborator
Author
|
@swift-ci please test source compatibility |
Collaborator
Author
|
The few source compat FAILs are clone failures that can be observed in some neighbouring builds too, so I think the patch will are alright. |
Collaborator
Author
|
@slavapestov Thank you for looking through this in such short terms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable us to allow members containing references to Self or associated types
only in covariant position to be used on an existential.