[ConstraintSystem] Remove implementation of operator designated types in the solver. #34315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci please smoke test |
xedin
reviewed
Oct 15, 2020
| // us to eliminate behavior that is exponential in the number of | ||
| // operators in the expression. | ||
| if (getASTContext().TypeCheckerOpts.SolverEnableOperatorDesignatedTypes) { | ||
| if (auto *disjunction = selectApplyDisjunction()) |
Contributor
There was a problem hiding this comment.
I think selectApplyDisjunction could also be removed now right?
Member
Author
There was a problem hiding this comment.
Ah you're right, thanks for catching that!
xedin
approved these changes
Oct 15, 2020
Contributor
xedin
left a comment
xedin
left a comment
There was a problem hiding this comment.
LGTM! I left a comment inline about selectApplyDisjunction.
by the operator designated types implementation.
Member
Author
|
@swift-ci please smoke test |
beccadax
added a commit
to beccadax/swift
that referenced
this pull request
Aug 3, 2021
Designated types were removed from the constraint solver in swiftlang#34315, but they are currently still represented in the AST and fully checked. This change removes them as completely as possible without breaking source compatibility (mainly with old swiftinterfaces) or changing the SwiftSyntax tree. Designated types are still parsed, but they are dropped immediately and a warning is diagnosed. During decl checking we also still check if the precedence group is really a designated type, but only so that we can diagnose a warning and fall back to DefaultPrecedence. This change also fixes an apparent bug in the parser where we did not diagnose operator declarations that contained a `:` followed by a non-identifier token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
-solver-enable-operator-designated-typesflag and implementation in the solver. This experimental feature is no longer being explored, and we're implementing other approaches to improving constraint solver performance that break this feature.There's a little more to remove (the
-enable-operator-designated-typesflag enables designated types in the parser, and designated type syntax is adopted in the standard library) but this lets me make more progress on chipping away at solver performance hacks.