Skip to content

Build libdispatch with its own module cache #34638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2020
Merged

Build libdispatch with its own module cache #34638

merged 2 commits into from
Nov 10, 2020

Conversation

@edymtt
Copy link
Contributor

@edymtt edymtt commented Nov 9, 2020

Some of the bots in CI run multiple jobs, so we need to be sure
libdispatch compilations do not attempt to share the module cache.

Addresses rdar://68100533

@edymtt
Build libdispatch with its own module cache
51bebba 
Some of the bots in CI run multiple jobs, so we need to be sure
libdispatch compilations do not attempt to share the module cache.

Addresses rdar://68100533
@edymtt
Copy link
Contributor Author

edymtt commented Nov 9, 2020

@swift-ci please smoke test macOS

@edymtt
Copy link
Contributor Author

edymtt commented Nov 9, 2020

@swift-ci please test Linux

@edymtt
Copy link
Contributor Author

edymtt commented Nov 9, 2020

@swift-ci please test Windows

@edymtt
Copy link
Contributor Author

edymtt commented Nov 9, 2020

@swift-ci Please Build Toolchain Linux Platform

shahmishal
shahmishal reviewed Nov 9, 2020
View reviewed changes
@swift-ci
Copy link
Contributor

swift-ci commented Nov 9, 2020

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 51bebba

Install command
tar zxf swift-PR-34638-486-ubuntu16.04.tar.gz
More info

xymus
xymus approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@xymus xymus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! I've only seen this failure in libdispatch but we should keep an eye out to apply this in more projects if they fail on pcm related errors.

@edymtt @shahmishal
Update flag type as per review feedback
045211c 
Co-authored-by: Mishal Shah <shahmishal@users.noreply.github.com>
@edymtt
Copy link
Contributor Author

edymtt commented Nov 9, 2020

@swift-ci please smoke test macOS

@edymtt
Copy link
Contributor Author

edymtt commented Nov 9, 2020

@swift-ci please test Linux

@edymtt
Copy link
Contributor Author

edymtt commented Nov 9, 2020

@swift-ci please test Windows

@edymtt
Copy link
Contributor Author

edymtt commented Nov 9, 2020

@swift-ci Please Build Toolchain Linux Platform

@edymtt
Copy link
Contributor Author

edymtt commented Nov 9, 2020

@swift-ci please clean test Windows

2 similar comments
@edymtt
Copy link
Contributor Author

edymtt commented Nov 9, 2020

@swift-ci please clean test Windows

@edymtt
Copy link
Contributor Author

edymtt commented Nov 9, 2020

@swift-ci please clean test Windows

@swift-ci
Copy link
Contributor

swift-ci commented Nov 9, 2020

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 045211c

Install command
tar zxf swift-PR-34638-487-ubuntu16.04.tar.gz
More info

@edymtt
Copy link
Contributor Author

edymtt commented Nov 9, 2020

@swift-ci please smoke test macOS

@edymtt edymtt merged commit f4b86c9 into swiftlang:main Nov 10, 2020
@edymtt edymtt deleted the separate-modulecache-for-libdispatch branch November 10, 2020 15:06
ainu-bot added a commit to google/swift that referenced this pull request Nov 10, 2020
@ainu-bot
Merge branch 'main' of github.com:apple/swift into tensorflow-stage
7f6d16b 
* 'main' of github.com:apple/swift:
  Build libdispatch with its own module cache (swiftlang#34638)
edymtt added a commit to edymtt/swift that referenced this pull request Jan 14, 2021
@edymtt
Build libdispatch with its own module cache (swiftlang#34638)
3ee5411 
Some of the bots in CI run multiple jobs, so we need to be sure
libdispatch compilations do not attempt to share the module cache.

Addresses rdar://68100533

(cherry picked from commit f4b86c9)
@edymtt edymtt mentioned this pull request Jan 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahmishal shahmishal shahmishal left review comments

@compnerd compnerd compnerd approved these changes

@xymus xymus xymus approved these changes

@vsapsai vsapsai Awaiting requested review from vsapsai

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@edymtt @swift-ci @compnerd @xymus @shahmishal