Skip to content

[TypeChecker] Un-XFAIL perf test-case for rdar://23620262 #35127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xedin merged 1 commit into from
Dec 18, 2020
Merged

[TypeChecker] Un-XFAIL perf test-case for rdar://23620262 #35127

xedin merged 1 commit into from
Dec 18, 2020

Conversation

@xedin
Copy link
Contributor

@xedin xedin commented Dec 16, 2020

Resolves: rdar://problem/38378503

@xedin
Copy link
Contributor Author

xedin commented Dec 16, 2020

@swift-ci please clean test

@xedin
Copy link
Contributor Author

xedin commented Dec 16, 2020

I think this one has been fixed by @hborla's changes in #34399.

hborla
hborla approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@hborla hborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! I didn't even think to check for XFAIL'd "fast" tests

@swift-ci
Copy link
Contributor

swift-ci commented Dec 16, 2020

Build failed
Swift Test Linux Platform
Git Sha - 0d040e2

@xedin
Copy link
Contributor Author

xedin commented Dec 16, 2020

@swift-ci please test Linux platform

@swift-ci
Copy link
Contributor

swift-ci commented Dec 16, 2020

Build failed
Swift Test OS X Platform
Git Sha - 0d040e2

@xedin
Copy link
Contributor Author

xedin commented Dec 17, 2020

@swift-ci please test macOS platform

@xedin
Copy link
Contributor Author

xedin commented Dec 17, 2020

Let’s run macOS a couple more times to ensure that there is no flakiness.

@xedin
Copy link
Contributor Author

xedin commented Dec 17, 2020

@swift-ci please test macOS platform

2 similar comments
@xedin
Copy link
Contributor Author

xedin commented Dec 17, 2020

@swift-ci please test macOS platform

@xedin
Copy link
Contributor Author

xedin commented Dec 17, 2020

@swift-ci please test macOS platform

@swift-ci
Copy link
Contributor

swift-ci commented Dec 17, 2020

Build failed
Swift Test OS X Platform
Git Sha - 0d040e2

@xedin
Copy link
Contributor Author

xedin commented Dec 17, 2020

@swift-ci please test macOS platform

1 similar comment
@xedin
Copy link
Contributor Author

xedin commented Dec 17, 2020

@swift-ci please test macOS platform

@swift-ci
Copy link
Contributor

swift-ci commented Dec 18, 2020

Build failed
Swift Test OS X Platform
Git Sha - 0d040e2

@xedin
Copy link
Contributor Author

xedin commented Dec 18, 2020

@swift-ci please test macOS platform

@swift-ci
Copy link
Contributor

swift-ci commented Dec 18, 2020

Build failed
Swift Test OS X Platform
Git Sha - 0d040e2

@xedin
Copy link
Contributor Author

xedin commented Dec 18, 2020

@swift-ci please test macOS platform

@xedin xedin merged commit e985d97 into swiftlang:main Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hborla hborla hborla approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xedin @swift-ci @hborla