Skip to content

CMake: disable libdispatch when targeting Wasm/WASI #39274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

MaxDesiatov
Copy link
Contributor

Wasm/WASI doesn't currently support multi-threading, and libdispatch should be disabled when building for this target.

Related to SR-12097.

@MaxDesiatov
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, this seems fine from a wont break anything for non-WASI, but this really needs to get resolved.

@MaxDesiatov MaxDesiatov merged commit a723e6d into main Sep 15, 2021
@MaxDesiatov MaxDesiatov deleted the maxd/wasi-libdispatch branch September 15, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants